Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

[Markus Armbruster]

Philippe Mathieu-Daudé <address@hidden> writes:

> On 5/26/20 9:38 AM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <address@hidden> writes:
>> 
>>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> 
>> A brief note on why restricting "to machine code" is useful would be
>> nice.  Same for the other patches.
>> 
>> Acked-by: Markus Armbruster <address@hidden>
>> 
>
> What about this?
>
> "QEMU can do system-mode and user-mode emulation.
> Only system mode emulate a machine.
> Remove this feature from the user-mode emulation."

Is is a feature of user-mode emulation before the patch?  Or is it just
dead code?

Hint: QMP commands tend to be dead code when the program doesn't expose
a QMP monitor :)