Re: [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return

From:	Eric Blake
Subject:	Re: [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return bool, not void
Date:	Thu, 2 Jul 2020 11:35:57 -0500
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 7/2/20 10:49 AM, Markus Armbruster wrote:

See recent commit "error: Document Error API usage rules" for
rationale.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---


Reviewed-by: Eric Blake <eblake@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 19/44] block/parallels: Simplify parallels_open() after previous commit, (continued)
- [PATCH v2 19/44] block/parallels: Simplify parallels_open() after previous commit, Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 19/44] block/parallels: Simplify parallels_open() after previous commit, Vladimir Sementsov-Ogievskiy, 2020/07/03
    - Re: [PATCH v2 19/44] block/parallels: Simplify parallels_open() after previous commit, Markus Armbruster, 2020/07/04
- [PATCH v2 27/44] qom: Make functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/02
- [PATCH v2 10/44] qemu-option: Factor out helper opt_create(), Markus Armbruster, 2020/07/02
- [PATCH v2 42/44] qemu-img: Ignore Error objects where the return value suffices, Markus Armbruster, 2020/07/02
- [PATCH v2 37/44] error: Reduce unnecessary error propagation, Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 37/44] error: Reduce unnecessary error propagation, Eric Blake, 2020/07/02
    - Re: [PATCH v2 37/44] error: Reduce unnecessary error propagation, Markus Armbruster, 2020/07/03
- [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return bool, not void, Eric Blake <=
  - Re: [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return bool, not void, Vladimir Sementsov-Ogievskiy, 2020/07/03
    - Re: [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/04
- [PATCH v2 30/44] qom: Make functions taking Error ** return bool, not 0/-1, Markus Armbruster, 2020/07/02
- [PATCH v2 07/44] qemu-option: Make uses of find_desc_by_name() more similar, Markus Armbruster, 2020/07/02
- [PATCH v2 18/44] qapi: Use returned bool to check for failure, manual part, Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 18/44] qapi: Use returned bool to check for failure, manual part, Vladimir Sementsov-Ogievskiy, 2020/07/03
- [PATCH v2 33/44] error: Avoid unnecessary error_propagate() after error_setg(), Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 33/44] error: Avoid unnecessary error_propagate() after error_setg(), Eric Blake, 2020/07/02
    - Re: [PATCH v2 33/44] error: Avoid unnecessary error_propagate() after error_setg(), Markus Armbruster, 2020/07/03
- Re: [PATCH v2 00/44] Less clumsy error checking, Markus Armbruster, 2020/07/02

Prev by Date: Re: [PATCH v2 14/44] block: Avoid error accumulation in bdrv_img_create()
Next by Date: Re: [PATCH v2 00/44] Less clumsy error checking
Previous by thread: [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return bool, not void
Next by thread: Re: [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return bool, not void
Index(es):
- Date
- Thread