Re: [PATCH v2 18/44] qapi: Use returned bool to check for failure, manua

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 18/44] qapi: Use returned bool to check for failure, manua

From:	Vladimir Sementsov-Ogievskiy
Subject:	Re: [PATCH v2 18/44] qapi: Use returned bool to check for failure, manual part
Date:	Fri, 3 Jul 2020 18:10:46 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

02.07.2020 18:49, Markus Armbruster wrote:

The previous commit used Coccinelle to convert from checking the Error
object to checking the return value.  Convert a few more manually.
Also tweak control flow in places to conform to the conventional "if
error bail out" pattern.

Signed-off-by: Markus Armbruster<armbru@redhat.com>
Reviewed-by: Eric Blake<eblake@redhat.com>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 37/44] error: Reduce unnecessary error propagation, (continued)
- [PATCH v2 37/44] error: Reduce unnecessary error propagation, Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 37/44] error: Reduce unnecessary error propagation, Eric Blake, 2020/07/02
    - Re: [PATCH v2 37/44] error: Reduce unnecessary error propagation, Markus Armbruster, 2020/07/03
- [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return bool, not void, Eric Blake, 2020/07/02
  - Re: [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return bool, not void, Vladimir Sementsov-Ogievskiy, 2020/07/03
    - Re: [PATCH v2 16/44] qapi: Make visitor functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/04
- [PATCH v2 30/44] qom: Make functions taking Error ** return bool, not 0/-1, Markus Armbruster, 2020/07/02
- [PATCH v2 07/44] qemu-option: Make uses of find_desc_by_name() more similar, Markus Armbruster, 2020/07/02
- [PATCH v2 18/44] qapi: Use returned bool to check for failure, manual part, Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 18/44] qapi: Use returned bool to check for failure, manual part, Vladimir Sementsov-Ogievskiy <=
- [PATCH v2 33/44] error: Avoid unnecessary error_propagate() after error_setg(), Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 33/44] error: Avoid unnecessary error_propagate() after error_setg(), Eric Blake, 2020/07/02
    - Re: [PATCH v2 33/44] error: Avoid unnecessary error_propagate() after error_setg(), Markus Armbruster, 2020/07/03
- Re: [PATCH v2 00/44] Less clumsy error checking, Markus Armbruster, 2020/07/02
- [PATCH v2 35/44] error: Eliminate error_propagate() with Coccinelle, part 2, Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 35/44] error: Eliminate error_propagate() with Coccinelle, part 2, Eric Blake, 2020/07/02
    - Re: [PATCH v2 35/44] error: Eliminate error_propagate() with Coccinelle, part 2, Markus Armbruster, 2020/07/03
- [PATCH v2 39/44] qapi: Smooth visitor error checking in generated code, Markus Armbruster, 2020/07/02
- [PATCH v2 40/44] qapi: Purge error_propagate() from QAPI core, Markus Armbruster, 2020/07/02
- [PATCH v2 38/44] qapi: Smooth another visitor error checking pattern, Markus Armbruster, 2020/07/02

Prev by Date: Re: [PATCH v7 15/17] hw/sd/sdcard: Correctly display the command name in trace events
Next by Date: Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error
Previous by thread: [PATCH v2 18/44] qapi: Use returned bool to check for failure, manual part
Next by thread: [PATCH v2 33/44] error: Avoid unnecessary error_propagate() after error_setg()
Index(es):
- Date
- Thread