[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 22/22] block/export: Add query-block-exports
From: |
Max Reitz |
Subject: |
Re: [RFC PATCH 22/22] block/export: Add query-block-exports |
Date: |
Wed, 19 Aug 2020 13:04:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 13.08.20 18:29, Kevin Wolf wrote:
> This adds a simple QMP command to query the list of block exports.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qapi/block-export.json | 33 +++++++++++++++++++++++++++++++++
> block/export/export.c | 23 +++++++++++++++++++++++
> 2 files changed, 56 insertions(+)
>
> diff --git a/qapi/block-export.json b/qapi/block-export.json
> index a067de2ba3..0b184bbd7c 100644
> --- a/qapi/block-export.json
> +++ b/qapi/block-export.json
> @@ -226,3 +226,36 @@
> ##
> { 'command': 'block-export-del',
> 'data': { 'id': 'str', '*mode': 'BlockExportRemoveMode' } }
> +
> +##
> +# @BlockExportInfo:
> +#
> +# Information about a single block export.
> +#
> +# @id: The unique identifier for the block export
> +#
> +# @type: This field is returned only for compatibility reasons, it should
> +# not be used (always returns 'unknown')
Äh?
I don’t understand. It looks like it definitely doesn’t always return
“unknown”. Also, the “compatibility reasons” aren’t really immediately
clear to me... :?
Max
signature.asc
Description: OpenPGP digital signature
- Re: [RFC PATCH 19/22] block/export: Move strong user reference to block_exports, (continued)
[RFC PATCH 18/22] block/export: Add 'id' option to block-export-add, Kevin Wolf, 2020/08/13
[RFC PATCH 17/22] block/export: Add blk_exp_close_all(_type), Kevin Wolf, 2020/08/13
[RFC PATCH 20/22] block/export: Add block-export-del, Kevin Wolf, 2020/08/13
[RFC PATCH 22/22] block/export: Add query-block-exports, Kevin Wolf, 2020/08/13
- Re: [RFC PATCH 22/22] block/export: Add query-block-exports,
Max Reitz <=
[RFC PATCH 21/22] block/export: Move blk to BlockExport, Kevin Wolf, 2020/08/13