Re: [RFC PATCH 22/22] block/export: Add query-block-exports

[Kevin Wolf]

Am 19.08.2020 um 13:04 hat Max Reitz geschrieben:
> On 13.08.20 18:29, Kevin Wolf wrote:
> > This adds a simple QMP command to query the list of block exports.
> > 
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> >  qapi/block-export.json | 33 +++++++++++++++++++++++++++++++++
> >  block/export/export.c  | 23 +++++++++++++++++++++++
> >  2 files changed, 56 insertions(+)
> > 
> > diff --git a/qapi/block-export.json b/qapi/block-export.json
> > index a067de2ba3..0b184bbd7c 100644
> > --- a/qapi/block-export.json
> > +++ b/qapi/block-export.json
> > @@ -226,3 +226,36 @@
> >  ##
> >  { 'command': 'block-export-del',
> >    'data': { 'id': 'str', '*mode': 'BlockExportRemoveMode' } }
> > +
> > +##
> > +# @BlockExportInfo:
> > +#
> > +# Information about a single block export.
> > +#
> > +# @id: The unique identifier for the block export
> > +#
> > +# @type: This field is returned only for compatibility reasons, it should
> > +#        not be used (always returns 'unknown')
> 
> Äh?
> 
> I don’t understand.  It looks like it definitely doesn’t always return
> “unknown”.  Also, the “compatibility reasons” aren’t really immediately
> clear to me... :?

Oops, this seems to be copied from BlockInfo and I forgot to change it...

Kevin

signature.asc
Description: PGP signature