qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 01/10] block: Add a 'flags' param to bdrv_{pread,pwrite,pw


From: Hanna Reitz
Subject: Re: [PATCH v5 01/10] block: Add a 'flags' param to bdrv_{pread,pwrite,pwrite_sync}()
Date: Mon, 4 Jul 2022 13:48:12 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 09.06.22 17:27, Alberto Faria wrote:
For consistency with other I/O functions, and in preparation to
implement them using generated_co_wrapper.

Callers were updated using this Coccinelle script:

     @@ expression child, offset, buf, bytes; @@
     - bdrv_pread(child, offset, buf, bytes)
     + bdrv_pread(child, offset, buf, bytes, 0)

     @@ expression child, offset, buf, bytes; @@
     - bdrv_pwrite(child, offset, buf, bytes)
     + bdrv_pwrite(child, offset, buf, bytes, 0)

     @@ expression child, offset, buf, bytes; @@
     - bdrv_pwrite_sync(child, offset, buf, bytes)
     + bdrv_pwrite_sync(child, offset, buf, bytes, 0)

Resulting overly-long lines were then fixed by hand.

Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
  block/blklogwrites.c             |  4 +--
  block/bochs.c                    |  6 ++--
  block/cloop.c                    | 10 +++---
  block/crypto.c                   |  4 +--
  block/dmg.c                      | 24 +++++++-------
  block/io.c                       | 13 ++++----
  block/parallels-ext.c            |  4 +--
  block/parallels.c                | 12 +++----
  block/qcow.c                     | 27 ++++++++-------
  block/qcow2-bitmap.c             | 14 ++++----
  block/qcow2-cache.c              |  7 ++--
  block/qcow2-cluster.c            | 21 ++++++------
  block/qcow2-refcount.c           | 42 +++++++++++------------
  block/qcow2-snapshot.c           | 39 +++++++++++-----------
  block/qcow2.c                    | 44 ++++++++++++------------
  block/qed.c                      |  8 ++---
  block/vdi.c                      | 10 +++---
  block/vhdx-log.c                 | 19 +++++------
  block/vhdx.c                     | 32 ++++++++++--------
  block/vmdk.c                     | 57 ++++++++++++++------------------
  block/vpc.c                      | 19 ++++++-----
  block/vvfat.c                    |  7 ++--
  include/block/block-io.h         |  7 ++--
  tests/unit/test-block-iothread.c |  8 ++---
  24 files changed, 219 insertions(+), 219 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]