qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 02/10] block: Change bdrv_{pread, pwrite, pwrite_sync}() p


From: Hanna Reitz
Subject: Re: [PATCH v5 02/10] block: Change bdrv_{pread, pwrite, pwrite_sync}() param order
Date: Mon, 4 Jul 2022 13:48:31 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 09.06.22 17:27, Alberto Faria wrote:
Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.

Callers were updated using this Coccinelle script:

     @@ expression child, offset, buf, bytes, flags; @@
     - bdrv_pread(child, offset, buf, bytes, flags)
     + bdrv_pread(child, offset, bytes, buf, flags)

     @@ expression child, offset, buf, bytes, flags; @@
     - bdrv_pwrite(child, offset, buf, bytes, flags)
     + bdrv_pwrite(child, offset, bytes, buf, flags)

     @@ expression child, offset, buf, bytes, flags; @@
     - bdrv_pwrite_sync(child, offset, buf, bytes, flags)
     + bdrv_pwrite_sync(child, offset, bytes, buf, flags)

Resulting overly-long lines were then fixed by hand.

Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
  block/blklogwrites.c             |  6 ++--
  block/bochs.c                    | 10 +++---
  block/cloop.c                    | 10 +++---
  block/crypto.c                   |  4 +--
  block/dmg.c                      | 26 +++++++--------
  block/io.c                       | 12 +++----
  block/parallels-ext.c            |  6 ++--
  block/parallels.c                | 10 +++---
  block/qcow.c                     | 34 +++++++++----------
  block/qcow2-bitmap.c             | 14 ++++----
  block/qcow2-cache.c              |  8 ++---
  block/qcow2-cluster.c            | 22 ++++++-------
  block/qcow2-refcount.c           | 56 +++++++++++++++++---------------
  block/qcow2-snapshot.c           | 48 +++++++++++++--------------
  block/qcow2.c                    | 47 ++++++++++++++-------------
  block/qed.c                      |  8 ++---
  block/vdi.c                      | 14 ++++----
  block/vhdx-log.c                 | 18 +++++-----
  block/vhdx.c                     | 28 ++++++++--------
  block/vmdk.c                     | 50 ++++++++++++++--------------
  block/vpc.c                      | 22 ++++++-------
  block/vvfat.c                    | 10 +++---
  include/block/block-io.h         | 10 +++---
  tests/unit/test-block-iothread.c |  8 ++---
  24 files changed, 242 insertions(+), 239 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]