qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 09/21] jobs: use job locks also in the unit tests


From: Emanuele Giuseppe Esposito
Subject: Re: [PATCH v9 09/21] jobs: use job locks also in the unit tests
Date: Tue, 19 Jul 2022 14:00:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0


Am 11/07/2022 um 15:08 schrieb Vladimir Sementsov-Ogievskiy:
> 
> That made me ask:
> 
> 1. Are all tests always run in main loop? If yes, why to protect status
> reading in test_complete_in_standby() ?
> 
> 2. Maybe, we don't need to protect anything here? Why to protect other
> things if we run everything in main loop?

I think it's still good example and practice to protect a function if it
needs to be protected and its name ends with _locked. It would just
confuse the reader if we don't protect it.

Emanuele




reply via email to

[Prev in Thread] Current Thread [Next in Thread]