qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 69c918: tcg: Save/restore vecop_list around m


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 69c918: tcg: Save/restore vecop_list around minmax fallback
Date: Sun, 19 Jul 2020 11:30:25 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 69c918d2ef319ac63cd759c527debc2a2bdf3a0c
      
https://github.com/qemu/qemu/commit/69c918d2ef319ac63cd759c527debc2a2bdf3a0c
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M tcg/tcg-op-vec.c

  Log Message:
  -----------
  tcg: Save/restore vecop_list around minmax fallback

Forgetting this asserts when tcg_gen_cmp_vec is called from
within tcg_gen_cmpsel_vec.

Fixes: 72b4c792c7a
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: a7ba744f4082abbd3e36a9265dd1682ad0980477
      
https://github.com/qemu/qemu/commit/a7ba744f4082abbd3e36a9265dd1682ad0980477
  Author: Luc Michel <luc.michel@greensocs.com>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M accel/tcg/cpu-exec.c

  Log Message:
  -----------
  tcg/cpu-exec: precise single-stepping after an exception

When single-stepping with a debugger attached to QEMU, and when an
exception is raised, the debugger misses the first instruction after the
exception:

$ qemu-system-aarch64 -M virt -display none -cpu cortex-a53 -s -S

$ aarch64-linux-gnu-gdb
GNU gdb (GDB) 9.2
[...]
(gdb) tar rem :1234
Remote debugging using :1234
warning: No executable has been specified and target does not support
determining executable automatically.  Try using the "file" command.
0x0000000000000000 in ?? ()
(gdb) # writing nop insns to 0x200 and 0x204
(gdb) set *0x200 = 0xd503201f
(gdb) set *0x204 = 0xd503201f
(gdb) # 0x0 address contains 0 which is an invalid opcode.
(gdb) # The CPU should raise an exception and jump to 0x200
(gdb) si
0x0000000000000204 in ?? ()

With this commit, the same run steps correctly on the first instruction
of the exception vector:

(gdb) si
0x0000000000000200 in ?? ()

Buglink: https://bugs.launchpad.net/qemu/+bug/757702
Signed-off-by: Luc Michel <luc.michel@greensocs.com>
Message-Id: <20200716193947.3058389-1-luc.michel@greensocs.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: ba3c35d9c4026361fd380b269dc6def9510b7166
      
https://github.com/qemu/qemu/commit/ba3c35d9c4026361fd380b269dc6def9510b7166
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M accel/tcg/cpu-exec.c

  Log Message:
  -----------
  tcg/cpu-exec: precise single-stepping after an interrupt

When single-stepping with a debugger attached to QEMU, and when an
interrupt is raised, the debugger misses the first instruction after
the interrupt.

Tested-by: Luc Michel <luc.michel@greensocs.com>
Reviewed-by: Luc Michel <luc.michel@greensocs.com>
Buglink: https://bugs.launchpad.net/qemu/+bug/757702
Message-Id: <20200717163029.2737546-1-richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 9fc87111005e8903785db40819af66b8f85b8b96
      
https://github.com/qemu/qemu/commit/9fc87111005e8903785db40819af66b8f85b8b96
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-07-19 (Sun, 19 Jul 2020)

  Changed paths:
    M accel/tcg/cpu-exec.c
    M tcg/tcg-op-vec.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20200717' into staging

Fix vector min/max fallback expansion
Fix singlestep from exception and interrupt

# gpg: Signature made Fri 17 Jul 2020 19:13:32 BST
# gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg:                issuer "richard.henderson@linaro.org"
# gpg: Good signature from "Richard Henderson <richard.henderson@linaro.org>" 
[full]
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* remotes/rth/tags/pull-tcg-20200717:
  tcg/cpu-exec: precise single-stepping after an interrupt
  tcg/cpu-exec: precise single-stepping after an exception
  tcg: Save/restore vecop_list around minmax fallback

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/b4421193299c...9fc87111005e



reply via email to

[Prev in Thread] Current Thread [Next in Thread]