[Qemu-commits] [qemu/qemu] 777618: migration/multifd: Rename threadinfo.c functions

[Richard Henderson]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 7776187aeaf4da3f4b8c8fbf24f1af39749a34b0
      
https://github.com/qemu/qemu/commit/7776187aeaf4da3f4b8c8fbf24f1af39749a34b0
  Author: Fabiano Rosas <farosas@suse.de>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/migration.c
    M migration/multifd.c
    M migration/threadinfo.c
    M migration/threadinfo.h

  Log Message:
  -----------
  migration/multifd: Rename threadinfo.c functions

We're about to add more functions to this file so make it use the same
coding style as the rest of the code.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <20230607161306.31425-2-farosas@suse.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: df6d0b9193dfb5b88ccf7bf9bcf1ab00cfea84bc
      
https://github.com/qemu/qemu/commit/df6d0b9193dfb5b88ccf7bf9bcf1ab00cfea84bc
  Author: Fabiano Rosas <farosas@suse.de>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/threadinfo.c
    M migration/threadinfo.h

  Log Message:
  -----------
  migration/multifd: Protect accesses to migration_threads

This doubly linked list is common for all the multifd and migration
threads so we need to avoid concurrent access.

Add a mutex to protect the data from concurrent access. This fixes a
crash when removing two MigrationThread objects from the list at the
same time during cleanup of multifd threads.

Fixes: 671326201d ("migration: Introduce interface query-migrationthreads")
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20230607161306.31425-3-farosas@suse.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 40b3b3dd39091ea916a1652f833995a58ca995e6
      
https://github.com/qemu/qemu/commit/40b3b3dd39091ea916a1652f833995a58ca995e6
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M softmmu/dirtylimit.c

  Log Message:
  -----------
  softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit"

dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid
if less than 0, so add parameter check for it.

Note that this patch also delete the unsolicited help message and
clean up the code.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <168618975839.6361.17407633874747688653-1@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 065f076c969aebffab876b88df3aac761809c1cf
      
https://github.com/qemu/qemu/commit/065f076c969aebffab876b88df3aac761809c1cf
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/migration-hmp-cmds.c
    M migration/options.c
    M qapi/migration.json

  Log Message:
  -----------
  qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

Introduce "x-vcpu-dirty-limit-period" migration experimental
parameter, which is in the range of 1 to 1000ms and used to
make dirtyrate calculation period configurable.

Currently with the "x-vcpu-dirty-limit-period" varies, the
total time of live migration changes, test results show the
optimal value of "x-vcpu-dirty-limit-period" ranges from
500ms to 1000 ms. "x-vcpu-dirty-limit-period" should be made
stable once it proves best value can not be determined with
developer's experiments.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <168618975839.6361.17407633874747688653-2@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 010d1ebfb7e79eb5153c4e9a6b97c34867c3db78
      
https://github.com/qemu/qemu/commit/010d1ebfb7e79eb5153c4e9a6b97c34867c3db78
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/migration-hmp-cmds.c
    M migration/options.c
    M qapi/migration.json

  Log Message:
  -----------
  qapi/migration: Introduce vcpu-dirty-limit parameters

Introduce "vcpu-dirty-limit" migration parameter used
to limit dirty page rate during live migration.

"vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are
two dirty-limit-related migration parameters, which can
be set before and during live migration by qmp
migrate-set-parameters.

This two parameters are used to help implement the dirty
page rate limit algo of migration.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <168618975839.6361.17407633874747688653-3@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: b8e0f5102f47c511598cf60e64cf9d6f1db07da6
      
https://github.com/qemu/qemu/commit/b8e0f5102f47c511598cf60e64cf9d6f1db07da6
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/options.c
    M migration/options.h
    M qapi/migration.json
    M softmmu/dirtylimit.c

  Log Message:
  -----------
  migration: Introduce dirty-limit capability

Introduce migration dirty-limit capability, which can
be turned on before live migration and limit dirty
page rate durty live migration.

Introduce migrate_dirty_limit function to help check
if dirty-limit capability enabled during live migration.

Meanwhile, refactor vcpu_dirty_rate_stat_collect
so that period can be configured instead of hardcoded.

dirty-limit capability is kind of like auto-converge
but using dirty limit instead of traditional cpu-throttle
to throttle guest down. To enable this feature, turn on
the dirty-limit capability before live migration using
migrate-set-capabilities, and set the parameters
"x-vcpu-dirty-limit-period", "vcpu-dirty-limit" suitably
to speed up convergence.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <168618975839.6361.17407633874747688653-4@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 12a8920e9c8c0d170ecd6332846a60d66454bfec
      
https://github.com/qemu/qemu/commit/12a8920e9c8c0d170ecd6332846a60d66454bfec
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  migration: Refactor auto-converge capability logic

Check if block migration is running before throttling
guest down in auto-converge way.

Note that this modification is kind of like code clean,
because block migration does not depend on auto-converge
capability, so the order of checks can be adjusted.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <168618975839.6361.17407633874747688653-5@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 00a8580b5be32810c961cd54f1bf80f44b6ae295
      
https://github.com/qemu/qemu/commit/00a8580b5be32810c961cd54f1bf80f44b6ae295
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  migration: Put the detection logic before auto-converge checking

This commit is prepared for the implementation of dirty-limit
convergence algo.

The detection logic of throttling condition can apply to both
auto-converge and dirty-limit algo, putting it's position
before the checking logic for auto-converge feature.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-ID: <168733225273.5845.15871826788879741674-6@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 4bc4305befdae17a8b39af186ea6bf80d808cf00
      
https://github.com/qemu/qemu/commit/4bc4305befdae17a8b39af186ea6bf80d808cf00
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/migration.c
    M migration/ram.c
    M migration/trace-events
    M softmmu/dirtylimit.c

  Log Message:
  -----------
  migration: Implement dirty-limit convergence algo

Implement dirty-limit convergence algo for live migration,
which is kind of like auto-converge algo but using dirty-limit
instead of cpu throttle to make migration convergent.

Enable dirty page limit if dirty_rate_high_cnt greater than 2
when dirty-limit capability enabled, Disable dirty-limit if
migration be canceled.

Note that "set_vcpu_dirty_limit", "cancel_vcpu_dirty_limit"
commands are not allowed during dirty-limit live migration.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <168733225273.5845.15871826788879741674-7@git.sr.ht>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 058880e1261478a14faa3c49b94a85d3d4c4d07d
      
https://github.com/qemu/qemu/commit/058880e1261478a14faa3c49b94a85d3d4c4d07d
  Author: Hyman Huang(黄勇) <yong.huang@smartx.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M include/sysemu/dirtylimit.h
    M migration/migration-hmp-cmds.c
    M migration/migration.c
    M qapi/migration.json
    M softmmu/dirtylimit.c

  Log Message:
  -----------
  migration: Extend query-migrate to provide dirty page limit info

Extend query-migrate to provide throttle time and estimated
ring full time with dirty-limit capability enabled, through which
we can observe if dirty limit take effect during live migration.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-ID: <168733225273.5845.15871826788879741674-8@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 1f37a80285ab5fc1fad0e5a342488adca7dbb96d
      
https://github.com/qemu/qemu/commit/1f37a80285ab5fc1fad0e5a342488adca7dbb96d
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: Be consistent for ppc

It makes no sense that we don't have the same configuration on both sides.

Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Message-ID: <20230608224943.3877-2-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: dcf32e9c593d3dbbc4ea9de3f87644bc8f2a42e0
      
https://github.com/qemu/qemu/commit/dcf32e9c593d3dbbc4ea9de3f87644bc8f2a42e0
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: Make machine_opts regular with other options

Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230608224943.3877-5-quintela@redhat.com>


  Commit: 597f0e22bc616812a21d89a72d64712d19dd173e
      
https://github.com/qemu/qemu/commit/597f0e22bc616812a21d89a72d64712d19dd173e
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: Create arch_opts

This will contain the options needed for both source and target.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-6-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 9c0334fa25f42dc675a7addcfff6bacda30930ad
      
https://github.com/qemu/qemu/commit/9c0334fa25f42dc675a7addcfff6bacda30930ad
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: machine_opts is really arch specific

And it needs to be in both source and target, so put it on arch_opts.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-7-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: d171e31319a8b970d6b8a733b3a9ef520fdcdb85
      
https://github.com/qemu/qemu/commit/d171e31319a8b970d6b8a733b3a9ef520fdcdb85
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: Create kvm_opts

So arch_dirty_ring option becomes one option like the others.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-8-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 000289810215be719d5055a530318390a5fba50a
      
https://github.com/qemu/qemu/commit/000289810215be719d5055a530318390a5fba50a
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: bootpath is the same for all tests and for all archs

So just make it a global variable.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-9-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 257eee994ea56a6cde2aaab7c819ddf51cc93a4f
      
https://github.com/qemu/qemu/commit/257eee994ea56a6cde2aaab7c819ddf51cc93a4f
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: Add bootfile_create/delete() functions

The bootsector code is read only from the guest (otherwise we are
going to have problems with it being read from both source and
destination).

Create a single copy for all the tests.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-10-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 641488c4dcb5cb16d4299db76c18530a6b8c0c46
      
https://github.com/qemu/qemu/commit/641488c4dcb5cb16d4299db76c18530a6b8c0c46
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: dirtylimit checks for x86_64 arch before

So no need to assert we are in x86_64.
Once there, refactor the function to remove useless variables.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-11-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: a9ab735df827df2833173cfa063e075be1ee6f13
      
https://github.com/qemu/qemu/commit/a9ab735df827df2833173cfa063e075be1ee6f13
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: simplify shmem_opts handling

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230608224943.3877-4-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: db7f103ae9897185594731c2a6cf8436c5ab4bb9
      
https://github.com/qemu/qemu/commit/db7f103ae9897185594731c2a6cf8436c5ab4bb9
  Author: Tejus GK <tejus.gk@nutanix.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: Update error description whenever migration fails

There are places in migration.c where the migration is marked failed with
MIGRATION_STATUS_FAILED, but the failure reason is never updated. Hence
libvirt doesn't know why the migration failed when it queries for it.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com
Reviewed-by: Juan Quintela <quintela@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Tejus GK <tejus.gk@nutanix.com>
Message-ID: <20230621130940.178659-2-tejus.gk@nutanix.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: da97fa652ac82d6f36e68ef872d0b60ad33c2306
      
https://github.com/qemu/qemu/commit/da97fa652ac82d6f36e68ef872d0b60ad33c2306
  Author: Tejus GK <tejus.gk@nutanix.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: Refactor repeated call of yank_unregister_instance

In the function qmp_migrate(), yank_unregister_instance() gets called
twice which isn't required. Hence, refactoring it so that it gets called
during the local_error cleanup.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Tejus GK <tejus.gk@nutanix.com>
Message-ID: <20230621130940.178659-3-tejus.gk@nutanix.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: d602d03d622077f2b43ce0e4dffa32bd45ff2d72
      
https://github.com/qemu/qemu/commit/d602d03d622077f2b43ce0e4dffa32bd45ff2d72
  Author: Wei Wang <wei.w.wang@intel.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/options.c

  Log Message:
  -----------
  migration: enforce multifd and postcopy preempt to be set before incoming

qemu_start_incoming_migration needs to check the number of multifd
channels or postcopy ram channels to configure the backlog parameter (i.e.
the maximum length to which the queue of pending connections for sockfd
may grow) of listen(). So enforce the usage of postcopy-preempt and
multifd as below:
- need to use "-incoming defer" on the destination; and
- set_capability and set_parameter need to be done before migrate_incoming

Otherwise, disable the use of the features and report error messages to
remind users to adjust the commands.

Signed-off-by: Wei Wang <wei.w.wang@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230606101910.20456-2-wei.w.wang@intel.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Acked-by: Juan Quintela <quintela@redhat.com>


  Commit: fce5d326b7ba3d87f357fd03dda53dc1f3189cd3
      
https://github.com/qemu/qemu/commit/fce5d326b7ba3d87f357fd03dda53dc1f3189cd3
  Author: Wei Wang <wei.w.wang@intel.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  qtest/migration-tests.c: use "-incoming defer" for postcopy tests

The Postcopy preempt capability is expected to be set before incoming
starts, so change the postcopy tests to start with deferred incoming and
call migrate-incoming after the cap has been set.

Why the existing tests (without this patch) didn't fail?
There could be two reasons:
1) "backlog" specifies the number of pending connections. As long as the
   server accepts the connections faster than the clients side connecting,
   connection will succeed. For the preempt test, it uses only 2 channels,
   so very likely to not have pending connections.
2) per my tests (on kernel 6.2), the number of pending connections allowed
   is actually "backlog + 1", which is 2 in this case.
That said, the implementation of socket_start_incoming_migration_internal
expects "migrate defer" to be used, and for safety, change the test to
work with the expected usage.

Signed-off-by: Wei Wang <wei.w.wang@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230606101910.20456-3-wei.w.wang@intel.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: e4c8620e8a8f5b7447a2d913851373339835fda0
      
https://github.com/qemu/qemu/commit/e4c8620e8a8f5b7447a2d913851373339835fda0
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/qemu-file.c
    M migration/qemu-file.h
    M migration/savevm.c
    M migration/vmstate.c

  Log Message:
  -----------
  qemu-file: Rename qemu_file_transferred_ fast -> noflush

Fast don't say much.  Noflush indicates more clearly that it is like
qemu_file_transferred but without the flush.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20230530183941.7223-2-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 03654aefbf1198054ea6bffdbddff8a4159e7644
      
https://github.com/qemu/qemu/commit/03654aefbf1198054ea6bffdbddff8a4159e7644
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/savevm.c

  Log Message:
  -----------
  migration: Change qemu_file_transferred to noflush

We do a qemu_fclose() just after that, that also does a qemu_fflush(),
so remove one qemu_fflush().

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20230530183941.7223-3-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: b7c70fb8b5d7b4cd2fcabc5aa35ba68e64217d84
      
https://github.com/qemu/qemu/commit/b7c70fb8b5d7b4cd2fcabc5aa35ba68e64217d84
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/block.c

  Log Message:
  -----------
  migration: Use qemu_file_transferred_noflush() for block migration.

We only care about the amount of bytes transferred.  Flushing is done
by the system somewhere else.

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230530183941.7223-4-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 99de6b7dc51615290a36ee2e24ba75b9e05ae206
      
https://github.com/qemu/qemu/commit/99de6b7dc51615290a36ee2e24ba75b9e05ae206
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/qemu-file.c
    M migration/qemu-file.h

  Log Message:
  -----------
  qemu_file: Make qemu_file_is_writable() static

It is not used outside of qemu_file, and it shouldn't.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230530183941.7223-19-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 094db0df5e96a1c0d064f961819ddb45f6501e97
      
https://github.com/qemu/qemu/commit/094db0df5e96a1c0d064f961819ddb45f6501e97
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/qemu-file.c

  Log Message:
  -----------
  qemu-file: Simplify qemu_file_shutdown()

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230530183941.7223-20-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 64540f349a7c6dd17bf8beb02fa729053bf7dfce
      
https://github.com/qemu/qemu/commit/64540f349a7c6dd17bf8beb02fa729053bf7dfce
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/qemu-file.c
    M migration/qemu-file.h

  Log Message:
  -----------
  qemu-file: Make qemu_file_get_error_obj() static

It was not used outside of qemu_file.c anyways.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230530183941.7223-21-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: c53dc569d0a0fb76eaa83f353253a897914948f9
      
https://github.com/qemu/qemu/commit/c53dc569d0a0fb76eaa83f353253a897914948f9
  Author: Juan Quintela <quintela@redhat.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M migration/qemu-file.c
    M migration/qemu-file.h
    M migration/rdma.c

  Log Message:
  -----------
  migration/rdma: Split qemu_fopen_rdma() into input/output functions

This is how everything else in QEMUFile is structured.
As a bonus they are three less lines of code.

Reviewed-by: Peter Xu <peterx@redhat.com>
Message-ID: <20230530183941.7223-17-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 8db19d42dcd036e933d8471dcad919ade0331485
      
https://github.com/qemu/qemu/commit/8db19d42dcd036e933d8471dcad919ade0331485
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M include/sysemu/dirtylimit.h
    M migration/block.c
    M migration/migration-hmp-cmds.c
    M migration/migration.c
    M migration/multifd.c
    M migration/options.c
    M migration/options.h
    M migration/qemu-file.c
    M migration/qemu-file.h
    M migration/ram.c
    M migration/rdma.c
    M migration/savevm.c
    M migration/threadinfo.c
    M migration/threadinfo.h
    M migration/trace-events
    M migration/vmstate.c
    M qapi/migration.json
    M softmmu/dirtylimit.c
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  Merge tag 'next-pull-request' of https://gitlab.com/juan.quintela/qemu into 
staging

Migration Pull request (20230621)

In this pull request:

- fix for multifd thread creation (fabiano)
- dirtylimity (hyman)
  * migration-test will go on next PULL request, as it has failures.
- Improve error description (tejus)
- improve -incoming and set parameters before calling incoming (wei)
- migration atomic counters reviewed patches (quintela)
- migration-test refacttoring reviewed (quintela)

Please apply.

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEEGJn/jt6/WMzuA0uC9IfvGFhy1yMFAmSTrjUACgkQ9IfvGFhy
# 1yMMaA/8D2yT2L23rctfGxVPTJkpOw/UR286NvyUaxcLb5lxoffI0avNsIsNSqJV
# xZuWngCxNL9eUZyKdTQe0wDAKRTg0/ZtGNlGKgnaaHmCaOmPNYIDqCAVlOgPDscg
# /ZSdELXOjJPPeLV7HL5n4EfKBt1jnjh8l9wf6Lvlvlr65VqjdDFt33Lgm9QENbGb
# Qz+otatWxvLYxgpA6O+A4o2ivNLDRufkWICLD8PeGwW1RQKTko2oAqqXvr+L9dI/
# 4avN4xbF3XBThIJISCwJRsAr2NOEz7naHpB9mhJn/sQ0DtTimu35X8M3TnWOcWRr
# CcDgVl+nctiHAVFGZMdXs+yW/1MpwC6gDYQiPWfxGfjKZvPATnWEMbXbvR9Elcaj
# FjvRsdgtgCkSTCPidGrwAsGu/H7FLiK5XtlF/DBNT7a7UBeWyp+zSuThY6wJsMQT
# SMJiJf+dPSJ4eN9LKvee/D42kpeRde1eCHe7+Pm9MvN69G/1iQVKaQkbIct2oWOk
# i7xYots2wfrKlkm20LF5c+3AR812T3outB5GvnGldKJFi5bvPcdZilWEGkmIuj4F
# t2sndpNuaP/XnKAdMUEaCne15ziooO0fKQyfoXQzfjZxk3S8tVsxKGiZc6RwZlPL
# MqNyLTQ88aBZWj53DnMY7BUDCRzaPI8xBbz24hq7XIRmxi+/474=
# =QJ9G
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 22 Jun 2023 04:13:09 AM CEST
# gpg:                using RSA key 1899FF8EDEBF58CCEE034B82F487EF185872D723
# gpg: Good signature from "Juan Quintela <quintela@redhat.com>" [undefined]
# gpg:                 aka "Juan Quintela <quintela@trasno.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 1899 FF8E DEBF 58CC EE03  4B82 F487 EF18 5872 D723

* tag 'next-pull-request' of https://gitlab.com/juan.quintela/qemu: (30 commits)
  migration/rdma: Split qemu_fopen_rdma() into input/output functions
  qemu-file: Make qemu_file_get_error_obj() static
  qemu-file: Simplify qemu_file_shutdown()
  qemu_file: Make qemu_file_is_writable() static
  migration: Use qemu_file_transferred_noflush() for block migration.
  migration: Change qemu_file_transferred to noflush
  qemu-file: Rename qemu_file_transferred_ fast -> noflush
  qtest/migration-tests.c: use "-incoming defer" for postcopy tests
  migration: enforce multifd and postcopy preempt to be set before incoming
  migration: Refactor repeated call of yank_unregister_instance
  migration: Update error description whenever migration fails
  migration-test: simplify shmem_opts handling
  migration-test: dirtylimit checks for x86_64 arch before
  migration-test: Add bootfile_create/delete() functions
  migration-test: bootpath is the same for all tests and for all archs
  migration-test: Create kvm_opts
  migration-test: machine_opts is really arch specific
  migration-test: Create arch_opts
  migration-test: Make machine_opts regular with other options
  migration-test: Be consistent for ppc
  ...

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/67fe6ae41da6...8db19d42dcd0