[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/35] hmp_change(): don't access DeviceEncrypte
|
From: |
Luiz Capitulino |
|
Subject: |
Re: [Qemu-devel] [PATCH 13/35] hmp_change(): don't access DeviceEncrypted's data |
|
Date: |
Fri, 10 Aug 2012 11:36:53 -0300 |
On Fri, 10 Aug 2012 11:02:21 +0200
Markus Armbruster <address@hidden> wrote:
> Luiz Capitulino <address@hidden> writes:
>
> > It's not needed. The device name is already known and
> > monitor_read_block_device_key() knows how to do the rest. This overly
> > simplifies hmp_change().
>
> "overly"?
>
> My usual complaint about commit messages is that they fail to explain
> the change's purpose. Yours explains your reason just fine, but the
> description of what's done falls a bit short. I'd like to see something
> like "replace duplicated password prompting code by common
> monitor_read_block_device_key()".
Done, for v3.
- [Qemu-devel] [PATCH v2 00/35]: add new error format, Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 05/35] qerror: drop qerror_abort(), Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 07/35] qerror: QError: drop file, linenr, func, Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 12/35] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED, Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 02/35] qerror: QERR_AMBIGUOUS_PATH: drop %(object) from human msg, Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 09/35] qerror: don't delay error message construction, Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 13/35] hmp_change(): don't access DeviceEncrypted's data, Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 20/35] qapi: generate correct enum names for camel case enums, Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 17/35] block: block_int: include qerror.h, Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 03/35] qerror: QERR_DEVICE_ENCRYPTED: change error message, Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 24/35] error, qerror: add ErrorClass argument to error functions, Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 35/35] docs: writing-qmp-commands.txt: update error section, Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 33/35] qerror: drop qerror_table and qerror_format(), Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 31/35] error: drop error_get_qobject()/error_set_qobject(), Luiz Capitulino, 2012/08/07
- [Qemu-devel] [PATCH 11/35] qmp: query-block: add 'valid_encryption_key' field, Luiz Capitulino, 2012/08/07