[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [RFC 1/8] move qemu_irq typedef out of cpu-
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [Xen-devel] [RFC 1/8] move qemu_irq typedef out of cpu-common.h |
Date: |
Wed, 29 Aug 2012 17:36:04 +0200 |
On Tue, 21 Aug 2012 17:10:48 +0100
Peter Maydell <address@hidden> wrote:
> On 21 August 2012 16:42, Eduardo Habkost <address@hidden> wrote:
> > diff --git a/qemu-common.h b/qemu-common.h
> > index e5c2bcd..6677a30 100644
> > --- a/qemu-common.h
> > +++ b/qemu-common.h
> > @@ -273,7 +273,6 @@ typedef struct PCIEPort PCIEPort;
> > typedef struct PCIESlot PCIESlot;
> > typedef struct MSIMessage MSIMessage;
> > typedef struct SerialState SerialState;
> > -typedef struct IRQState *qemu_irq;
> > typedef struct PCMCIACardState PCMCIACardState;
> > typedef struct MouseTransformInfo MouseTransformInfo;
> > typedef struct uWireSlave uWireSlave;
> > diff --git a/sysemu.h b/sysemu.h
> > index 65552ac..f765821 100644
> > --- a/sysemu.h
> > +++ b/sysemu.h
> > @@ -9,6 +9,7 @@
> > #include "qapi-types.h"
> > #include "notify.h"
> > #include "main-loop.h"
> > +#include "hw/irq.h"
> >
> > /* vl.c */
>
> I'm not objecting to this patch if it helps us move forwards,
> but adding the #include to sysemu.h is effectively just adding
> the definition to another grabbag header (183 files include
> sysemu.h). It would be nicer long-term to separate out the
> one thing in this header that cares about qemu_irq (the extern
> declaration of qemu_system_powerdown).
> [I'm not really convinced that a qemu_irq is even the right
> way to signal "hey the system has actually powered down now"...]
Instead of global qemu_system_powerdown we could use notifiers like it's done
for suspend, I'll post patches today after testing them on target-i386.
BTW getting rid of qemu_system_powerdown is orthogonal to topic of this series.
I hope you won't object to this patch providing there will be follow on series
to deal with qemu_system_powerdown.
>
> -- PMM
>
> _______________________________________________
> Xen-devel mailing list
> address@hidden
> http://lists.xen.org/xen-devel
--
Regards,
Igor
- [Qemu-devel] [RFC 0/8] include qdev core in *-user, make CPU child of DeviceState, Eduardo Habkost, 2012/08/21
- [Qemu-devel] [RFC 4/8] cleanup error.h, included qapi-types.h aready has stdbool.h, Eduardo Habkost, 2012/08/21
- [Qemu-devel] [RFC 7/8] include core qdev code into *-user, too, Eduardo Habkost, 2012/08/21
- [Qemu-devel] [RFC 3/8] qapi-types.h doesn't really need to include qemu-common.h, Eduardo Habkost, 2012/08/21
- [Qemu-devel] [RFC 2/8] qdev: split up header so it can be used in cpu.h, Eduardo Habkost, 2012/08/21