[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 21/43] q35: expose mmcfg size as a property
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 21/43] q35: expose mmcfg size as a property |
Date: |
Mon, 14 Oct 2013 17:59:15 +0300 |
Address is already exposed, expose size for symmetry.
Reviewed-by: Gerd Hoffmann <address@hidden>
Tested-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Tested-by: Igor Mammedov <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
include/hw/pci/pcie_host.h | 1 +
hw/pci-host/q35.c | 14 ++++++++++++++
2 files changed, 15 insertions(+)
diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h
index 33d75bd..acca45e 100644
--- a/include/hw/pci/pcie_host.h
+++ b/include/hw/pci/pcie_host.h
@@ -29,6 +29,7 @@
OBJECT_CHECK(PCIExpressHost, (obj), TYPE_PCIE_HOST_BRIDGE)
#define PCIE_HOST_MCFG_BASE "MCFG"
+#define PCIE_HOST_MCFG_SIZE "mcfg_size"
/* pcie_host::base_addr == PCIE_BASE_ADDR_UNMAPPED when it isn't mapped. */
#define PCIE_BASE_ADDR_UNMAPPED ((hwaddr)-1ULL)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index e46f286..a051b58 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -109,6 +109,16 @@ static void q35_host_get_pci_hole64_end(Object *obj,
Visitor *v,
visit_type_uint64(v, &w64.end, name, errp);
}
+static void q35_host_get_mmcfg_size(Object *obj, Visitor *v,
+ void *opaque, const char *name,
+ Error **errp)
+{
+ PCIExpressHost *e = PCIE_HOST_BRIDGE(obj);
+ uint32_t value = e->size;
+
+ visit_type_uint32(v, &value, name, errp);
+}
+
static Property mch_props[] = {
DEFINE_PROP_UINT64(PCIE_HOST_MCFG_BASE, Q35PCIHost, parent_obj.base_addr,
MCH_HOST_BRIDGE_PCIEXBAR_DEFAULT),
@@ -160,6 +170,10 @@ static void q35_host_initfn(Object *obj)
q35_host_get_pci_hole64_end,
NULL, NULL, NULL, NULL);
+ object_property_add(obj, PCIE_HOST_MCFG_SIZE, "int",
+ q35_host_get_mmcfg_size,
+ NULL, NULL, NULL, NULL);
+
/* Leave enough space for the biggest MCFG BAR */
/* TODO: this matches current bios behaviour, but
* it's not a power of two, which means an MTRR
--
MST
- [Qemu-devel] [PULL 11/43] hw/pci: removed irq field from PCIDevice, (continued)
- [Qemu-devel] [PULL 11/43] hw/pci: removed irq field from PCIDevice, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 12/43] cleanup object.h: include error.h directly, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 13/43] qom: cleanup struct Error references, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 14/43] qom: add pointer to int property helpers, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 15/43] pci: fix up w64 size calculation helper, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 16/43] fw_cfg: interface to trigger callback on read, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 17/43] loader: support for unmapped ROM blobs, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 18/43] pcie_host: expose UNMAPPED macro, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 19/43] pcie_host: expose address format, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 20/43] q35: use macro for MCFG property name, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 21/43] q35: expose mmcfg size as a property,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 23/43] acpi: add rules to compile ASL source, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 25/43] acpi: ssdt pcihp: updat generated file, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 22/43] i386: add ACPI table files from seabios, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 26/43] loader: use file path size from fw_cfg.h, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 24/43] acpi: pre-compiled ASL files, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 27/43] i386: add bios linker/loader, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 28/43] loader: allow adding ROMs in done callbacks, Michael S. Tsirkin, 2013/10/14
- Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements, Paolo Bonzini, 2013/10/14