Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev

[Igor Mammedov]

On Mon, 09 Jun 2014 14:58:39 +0200
Paolo Bonzini <address@hidden> wrote:

> Il 09/06/2014 14:36, Igor Mammedov ha scritto:
> >> > +{ 'type': 'Memdev',
> >> > +  'data': {
> >> > +    'size':       'size',
> >> > +    'merge':      'bool',
> >> > +    'dump':       'bool',
> >> > +    'prealloc':   'bool',
> >> > +    'host-nodes': ['uint16'],
> >> > +    'policy':     'HostMemPolicy' }}
> >> > +
> >> > +##
> >> > +# @query-memdev:
> >> > +#
> >> > +# Returns information for all memory devices.
> >> > +#
> >> > +# Returns: a list of @Memdev.
> >> > +#
> >> > +# Since: 2.1
> >> > +##
> >> > +{ 'command': 'query-memdev', 'returns': ['Memdev'] }
> > Could we make it union, that returns MemdevRam + MemdevFile
> >
> > MemdevFile will have additional file-only specific properties.
> >
> 
> Which are the file-only properties (in the current definition of Memdev)?
in current none, but for file backend exposing 'path' property might be useful
alternatively instead of union we could add 'type' and optional 'path' fields
to Memdev

> 
> Paolo
> 


-- 
Regards,
  Igor