[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev |
Date: |
Mon, 09 Jun 2014 11:24:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 06/09/2014 04:25 AM, Hu Tao wrote:
> Add qmp command query-memdev to query for information
> of memory devices
>
> Signed-off-by: Hu Tao <address@hidden>
> ---
> numa.c | 72
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> qapi-schema.json | 34 ++++++++++++++++++++++++++
> qmp-commands.hx | 32 +++++++++++++++++++++++++
> 3 files changed, 138 insertions(+)
>
> +
> +##
> +# @Memdev:
> +#
> +# Information of memory device
> +#
> +# @size: memory device size
> +#
> +# @host-nodes: host nodes for its memory policy
> +#
> +# @policy: memory policy of memory device
> +#
You documented three parameters...
> +# Since: 2.1
> +##
> +
> +{ 'type': 'Memdev',
> + 'data': {
> + 'size': 'size',
> + 'merge': 'bool',
> + 'dump': 'bool',
> + 'prealloc': 'bool',
> + 'host-nodes': ['uint16'],
> + 'policy': 'HostMemPolicy' }}
...but implemented six, all listed as mandatory,...
> +Show memory devices information.
> +
> +
> +Example (1):
> +
> +-> { "execute": "query-memdev" }
> +<- { "return": [
> + {
> + "size": 536870912,
> + "host-nodes": [0, 1],
> + "policy": "bind"
> + },
...and then only demonstrate 3 in the example. Something's not quite right.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v4 00/29] NUMA series and hostmem improvements, (continued)
- [Qemu-devel] [PATCH v4 29/29] hmp: add info memdev, Hu Tao, 2014/06/09
- [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev, Hu Tao, 2014/06/09
- Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev, Igor Mammedov, 2014/06/09
- Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev, Paolo Bonzini, 2014/06/09
- Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev, Igor Mammedov, 2014/06/09
- Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev, Paolo Bonzini, 2014/06/09
- Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev, Igor Mammedov, 2014/06/09
- Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev, Eric Blake, 2014/06/09
Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev,
Eric Blake <=