Re: [Qemu-devel] [PATCH 0/5] ACPI memory hotplug: QMP interfaces

[Michael S. Tsirkin]

On Thu, Jun 05, 2014 at 04:36:03PM +0200, Igor Mammedov wrote:
> this is implemented  on top of v4 memory hotplug series:
> http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00129.html
> 
> Series adds following QMP commands:
>  - query-memory-devices
>  - query-acpi-ospm-status
> and event:
>  - ACPI_DEVICE_OST
> 
> Which could be used by management tools to query current
> state of memory devices (implemented only for PCDIMMDevice so far)
> and a related ACPI view of corresponding status of slots
> (ACPI Memory Device objects).
> 
> git tree for testing:
>    https://github.com/imammedo/qemu/commits/memory-hotplug-OST

Could you please address Eric's comments
(once all of them are in) and rebase
on top of latest?

I think these will be ok post soft freeze.
Thanks.


> Igor Mammedov (5):
>   qmp: add query-memory-devices command
>   acpi: introduce TYPE_ACPI_DEVICE_IF interface
>   acpi: implement ospm_status() method for PIIX4/ICH9_LPC devices
>   qmp: add query-acpi-ospm-status command
>   qmp: add ACPI_DEVICE_OST event handling
> 
>  docs/qmp/qmp-events.txt              |   10 ++++
>  hw/acpi/Makefile.objs                |    1 +
>  hw/acpi/acpi_interface.c             |   15 +++++
>  hw/acpi/ich9.c                       |    7 +++
>  hw/acpi/memory_hotplug.c             |   60 +++++++++++++++++++++-
>  hw/acpi/piix4.c                      |   11 ++++
>  hw/isa/lpc_ich9.c                    |    3 +
>  hw/mem/pc-dimm.c                     |   39 ++++++++++++++
>  include/hw/acpi/acpi_dev_interface.h |   43 +++++++++++++++
>  include/hw/acpi/ich9.h               |    3 +
>  include/hw/acpi/memory_hotplug.h     |    1 +
>  include/hw/mem/pc-dimm.h             |    2 +
>  include/monitor/monitor.h            |    1 +
>  monitor.c                            |    1 +
>  qapi-schema.json                     |   94 
> ++++++++++++++++++++++++++++++++++
>  qmp-commands.hx                      |   49 ++++++++++++++++++
>  qmp.c                                |   31 +++++++++++
>  stubs/Makefile.objs                  |    1 +
>  stubs/qmp_pc_dimm_device_list.c      |    7 +++
>  19 files changed, 378 insertions(+), 1 deletions(-)
>  create mode 100644 hw/acpi/acpi_interface.c
>  create mode 100644 include/hw/acpi/acpi_dev_interface.h
>  create mode 100644 stubs/qmp_pc_dimm_device_list.c