[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interfa
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface |
Date: |
Mon, 16 Jun 2014 09:32:18 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/05/2014 08:36 AM, Igor Mammedov wrote:
> ... it will be used to abstract generic ACPI bits from
> device that implements ACPI interface.
>
> ACPIOSTInfo type is used for passing-through raw _OST
> event/status codes reported by guest OS to a management
> layer. It lets management tools to interpret values
s/to //
> as specified by ACPI spec if it interested in it.
s/if it/if it is/
>
> QEMU doesn't encode these values as enum, since it
> doesn't need to handle them and it allows interface
> to scale well without any changes in QEMU while guest
> OS and management evolves in time.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> v2:
> - fix doc comments, describe not described fields
> - add slot-type field with DIMM type for now, which later
> we could extend to PCI slots and probably to CPUs
> - extend commit message describing why source/status
> are raw integers vs enum.
> ---
> hw/acpi/Makefile.objs | 1 +
> hw/acpi/acpi_interface.c | 15 ++++++++++++
> include/hw/acpi/acpi_dev_interface.h | 43
> ++++++++++++++++++++++++++++++++++
> qapi-schema.json | 31 ++++++++++++++++++++++++
> 4 files changed, 90 insertions(+), 0 deletions(-)
> create mode 100644 hw/acpi/acpi_interface.c
> create mode 100644 include/hw/acpi/acpi_dev_interface.h
>
> +## @ACPIOSTInfo
> +#
> +# OSPM Status Indication for a device
> +# For description of possible values of @source and @status fields
> +# see "_OST (OSPM Status Indication)" chapter of ACPI5.0 spec.
> +#
> +# @device: device ID accossiated with slot
s/accossiated/associated/
Missing #optional annotation
> +#
> +# @slot: slot ID, unique per slot of a given @slot-type
> +#
> +# @slot-type: type of the slot
> +#
> +# @source: an integer containing the source event
> +#
> +# @status: an integer containing the status code
> +#
> +# Since: 2.1
> +##
> +{ 'type': 'ACPIOSTInfo',
> + 'data' : { '*device': 'str',
> + 'slot': 'str',
> + 'slot-type': 'ACPISlotType',
> + 'source': 'int',
> + 'status': 'int' } }
>
Fix the docs, and you can add:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/5] ACPI memory hotplug: QMP interfaces, Igor Mammedov, 2014/06/05
- [Qemu-devel] [PATCH 1/5] qmp: add query-memory-devices command, Igor Mammedov, 2014/06/05
- [Qemu-devel] [PATCH 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface, Igor Mammedov, 2014/06/05
- Re: [Qemu-devel] [PATCH 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface,
Eric Blake <=
- [Qemu-devel] [PATCH 3/5] acpi: implement ospm_status() method for PIIX4/ICH9_LPC devices, Igor Mammedov, 2014/06/05
- [Qemu-devel] [PATCH 4/5] qmp: add query-acpi-ospm-status command, Igor Mammedov, 2014/06/05
- [Qemu-devel] [PATCH 5/5] qmp: add ACPI_DEVICE_OST event handling, Igor Mammedov, 2014/06/05
- Re: [Qemu-devel] [PATCH 0/5] ACPI memory hotplug: QMP interfaces, Igor Mammedov, 2014/06/16
- Re: [Qemu-devel] [PATCH 0/5] ACPI memory hotplug: QMP interfaces, Michael S. Tsirkin, 2014/06/16