[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] acpi: implement ospm_status() method for PI
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] acpi: implement ospm_status() method for PIIX4/ICH9_LPC devices |
Date: |
Mon, 16 Jun 2014 18:42:16 +0200 |
On Mon, 16 Jun 2014 10:14:16 -0600
Eric Blake <address@hidden> wrote:
> On 06/05/2014 08:36 AM, Igor Mammedov wrote:
> > ... using TYPE_ACPI_DEVICE_IF interface.
> > Which provides status reporting of ACPI declared memory devices
> >
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> > v2:
> > - set slot-type to DIMM
> > - take into account that 'device' field could be optional
> > ---
> > hw/acpi/ich9.c | 7 +++++++
> > hw/acpi/memory_hotplug.c | 31 +++++++++++++++++++++++++++++++
> > hw/acpi/piix4.c | 11 +++++++++++
> > hw/isa/lpc_ich9.c | 3 +++
> > include/hw/acpi/ich9.h | 3 +++
> > include/hw/acpi/memory_hotplug.h | 1 +
> > 6 files changed, 56 insertions(+), 0 deletions(-)
> >
>
> > +void acpi_memory_ospm_status(MemHotplugState *mem_st, ACPIOSTInfoList
> > ***list);
>
> Triple indirection looks unusual, but that doesn't make it wrong :)
I plan to move ACPI code inside of interface handlers and drop piix4/ich9 stubs
in favor of using QOM casting directly. So it would be -1 layer of indirection
and
not only for ospm_status().
In addition interface allows to avoid adding global function + stub where
functionality is not implemented.
>
> Reviewed-by: Eric Blake <address@hidden>
>
- [Qemu-devel] [PATCH 0/5] ACPI memory hotplug: QMP interfaces, Igor Mammedov, 2014/06/05
- [Qemu-devel] [PATCH 1/5] qmp: add query-memory-devices command, Igor Mammedov, 2014/06/05
- [Qemu-devel] [PATCH 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface, Igor Mammedov, 2014/06/05
- [Qemu-devel] [PATCH 3/5] acpi: implement ospm_status() method for PIIX4/ICH9_LPC devices, Igor Mammedov, 2014/06/05
- [Qemu-devel] [PATCH 4/5] qmp: add query-acpi-ospm-status command, Igor Mammedov, 2014/06/05
- [Qemu-devel] [PATCH 5/5] qmp: add ACPI_DEVICE_OST event handling, Igor Mammedov, 2014/06/05
- Re: [Qemu-devel] [PATCH 0/5] ACPI memory hotplug: QMP interfaces, Igor Mammedov, 2014/06/16
- Re: [Qemu-devel] [PATCH 0/5] ACPI memory hotplug: QMP interfaces, Michael S. Tsirkin, 2014/06/16