[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/14] virtio-scsi: add extra argument and return typ
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 11/14] virtio-scsi: add extra argument and return type to qemu_sgl_concat |
Date: |
Wed, 18 Jun 2014 15:26:51 +0200 |
Will be used for anylayout support.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/scsi/virtio-scsi.c | 27 ++++++++++++++++++++-------
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index ec9a536..0718626 100644
--- a/hw/scsi/virtio-scsi.c
+++ b/hw/scsi/virtio-scsi.c
@@ -95,14 +95,27 @@ static void virtio_scsi_bad_req(void)
exit(1);
}
-static void qemu_sgl_concat(VirtIOSCSIReq *req, struct iovec *sg,
- hwaddr *addr, int num)
+static size_t qemu_sgl_concat(VirtIOSCSIReq *req, struct iovec *iov,
+ hwaddr *addr, int num, size_t skip)
{
QEMUSGList *qsgl = &req->qsgl;
-
- while (num--) {
- qemu_sglist_add(qsgl, *(addr++), (sg++)->iov_len);
+ size_t copied = 0;
+
+ while (num) {
+ if (skip >= iov->iov_len) {
+ skip -= iov->iov_len;
+ } else {
+ qemu_sglist_add(qsgl, *addr + skip, iov->iov_len - skip);
+ copied += iov->iov_len - skip;
+ skip = 0;
+ }
+ iov++;
+ addr++;
+ num--;
}
+
+ assert(skip == 0);
+ return copied;
}
static int virtio_scsi_parse_req(VirtIOSCSIReq *req,
@@ -127,11 +140,11 @@ static int virtio_scsi_parse_req(VirtIOSCSIReq *req,
if (req->elem.out_num > 1) {
qemu_sgl_concat(req, &req->elem.out_sg[1],
&req->elem.out_addr[1],
- req->elem.out_num - 1);
+ req->elem.out_num - 1, 0);
} else {
qemu_sgl_concat(req, &req->elem.in_sg[1],
&req->elem.in_addr[1],
- req->elem.in_num - 1);
+ req->elem.in_num - 1, 0);
}
return 0;
--
1.8.3.1
- [Qemu-devel] [PULL 02/14] block/iscsi: fix potential segfault on early callback, (continued)
- [Qemu-devel] [PULL 02/14] block/iscsi: fix potential segfault on early callback, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PULL 03/14] block/iscsi: use 16 byte CDBs only when necessary, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PULL 04/14] scsi-disk.c: Fix compilation with -DDEBUG_SCSI, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PULL 05/14] scsi-disk: fix bug in scsi_block_new_request() introduced by commit 137745c, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PULL 06/14] scsi: Print command name in debug, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PULL 07/14] megasas: use PCI DMA API, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PULL 08/14] util: add return value to qemu_iovec_concat_iov, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PULL 09/14] virtio-scsi: start preparing for any_layout, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PULL 10/14] virtio-scsi: add target swap for VirtIOSCSICtrlTMFReq fields, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PULL 12/14] virtio-scsi: prepare sense data handling for any_layout, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PULL 11/14] virtio-scsi: add extra argument and return type to qemu_sgl_concat,
Paolo Bonzini <=
- [Qemu-devel] [PULL 13/14] virtio-scsi: introduce virtio_scsi_complete_cmd_req, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PULL 14/14] virtio-scsi: add support for the any_layout feature, Paolo Bonzini, 2014/06/18
- Re: [Qemu-devel] [PULL 00/14] SCSI changes for 2014-06-18, Peter Maydell, 2014/06/18