Re: [Qemu-devel] [PULL 00/14] SCSI changes for 2014-06-18

[Paolo Bonzini]

Il 18/06/2014 17:30, Peter Maydell ha scritto:
> On 18 June 2014 14:26, Paolo Bonzini <address@hidden> wrote:
> > The following changes since commit af44da87e926ff64260b95f4350d338c4fc113ca:
> >
> >   Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' 
> > into staging (2014-06-16 18:26:21 +0100)
> >
> > are available in the git repository at:
> >
> >
> >   git://github.com/bonzini/qemu.git scsi-next
> >
> > for you to fetch changes up to 3eff1f46f08a360a4ae9f834ce9fef4c45bf6f0f:
> >
> >   virtio-scsi: add support for the any_layout feature (2014-06-18 08:47:11 
> > +0200)
>
> Hi; I'm afraid this fails to build for me:

Looks like your libiscsi is too old.

Paolo

> /home/petmay01/linaro/qemu-for-merges/block/iscsi.c: In function
> ‘iscsi_co_generic_cb’:
> /home/petmay01/linaro/qemu-for-merges/block/iscsi.c:187:27: error:
> ‘SCSI_STATUS_BUSY’ undeclared (first use in this function)
>              if (status == SCSI_STATUS_BUSY) {
>                            ^
> /home/petmay01/linaro/qemu-for-merges/block/iscsi.c:187:27: note: each
> undeclared identifier is reported only once for each function it
> appears in
> /home/petmay01/linaro/qemu-for-merges/block/iscsi.c: In function
> ‘iscsi_co_writev’:
> /home/petmay01/linaro/qemu-for-merges/block/iscsi.c:394:41: error:
> passing argument 3 of ‘iscsi_write10_task’ makes pointer from integer
> without a cast [-Werror]
>                                          iscsi_co_generic_cb, &iTask);
>                                          ^
> In file included from /home/petmay01/linaro/qemu-for-merges/block/iscsi.c:43:0:
> /usr/include/iscsi/iscsi.h:610:1: note: expected ‘unsigned char *’ but
> argument is of type ‘uint64_t’
>  iscsi_write10_task(struct iscsi_context *iscsi, int lun,
>  ^
> /home/petmay01/linaro/qemu-for-merges/block/iscsi.c:394:41: error:
> passing argument 4 of ‘iscsi_write10_task’ makes integer from pointer
> without a cast [-Werror]
>                                          iscsi_co_generic_cb, &iTask);
>                                          ^
> In file included from /home/petmay01/linaro/qemu-for-merges/block/iscsi.c:43:0:
> /usr/include/iscsi/iscsi.h:610:1: note: expected ‘uint32_t’ but
> argument is of type ‘uint8_t *’
>  iscsi_write10_task(struct iscsi_context *iscsi, int lun,
>  ^
> /home/petmay01/linaro/qemu-for-merges/block/iscsi.c:394:41: error: too
> many arguments to function ‘iscsi_write10_task’
>                                          iscsi_co_generic_cb, &iTask);
>                                          ^
> In file included from /home/petmay01/linaro/qemu-for-merges/block/iscsi.c:43:0:
> /usr/include/iscsi/iscsi.h:610:1: note: declared here
>  iscsi_write10_task(struct iscsi_context *iscsi, int lun,
>  ^
> cc1: all warnings being treated as errors
> make: *** [block/iscsi.o] Error 1
>
>
> thanks
> -- PMM