qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest


From: Amos Kong
Subject: Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest
Date: Thu, 19 Jun 2014 11:57:45 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Jun 19, 2014 at 11:49:08AM +0800, Stefan Hajnoczi wrote:
> On Thu, Jun 19, 2014 at 12:24:13AM +0800, Amos Kong wrote:
> > +    for (i = MIN_PCI_SLOT; i <= MAX_PCI_SLOT; i++) {
> > +        for (j = MAX_PCI_FUNC; j >= 0; j--) {
> > +            if (j == MAX_PCI_FUNC) {
> > +                qmp_exec_hmp_cmd("", "drive_del drv-%x.%x", i, 0);
> > +            }
> 
> Why is only drv-%x.0 deleted?  Previous revisions of this patch series
> deleted all drives.

Hot-unplug any single function, all functions in the slot will be
removed. So once is enough.
 
> Stefan


-- 
                        Amos.

Attachment: pgpctQelqJRAY.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]