[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest
From: |
Amos Kong |
Subject: |
Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest |
Date: |
Thu, 19 Jun 2014 12:38:20 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jun 19, 2014 at 04:03:28AM +0000, Gonglei (Arei) wrote:
> Hi,
>
> > -----Original Message-----
> > From: Amos Kong [mailto:address@hidden
> > Sent: Thursday, June 19, 2014 11:58 AM
> > To: Stefan Hajnoczi
> > Cc: address@hidden; Gonglei (Arei); address@hidden;
> > address@hidden; address@hidden
> > Subject: Re: [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest
> >
> > On Thu, Jun 19, 2014 at 11:49:08AM +0800, Stefan Hajnoczi wrote:
> > > On Thu, Jun 19, 2014 at 12:24:13AM +0800, Amos Kong wrote:
> > > > + for (i = MIN_PCI_SLOT; i <= MAX_PCI_SLOT; i++) {
> > > > + for (j = MAX_PCI_FUNC; j >= 0; j--) {
> > > > + if (j == MAX_PCI_FUNC) {
> > > > + qmp_exec_hmp_cmd("", "drive_del drv-%x.%x", i, 0);
> > > > + }
> > >
> > > Why is only drv-%x.0 deleted? Previous revisions of this patch series
> > > deleted all drives.
> >
> > Hot-unplug any single function, all functions in the slot will be
> > removed. So once is enough.
> >
> IMHO, the below devices as the same as the drive about multifunction
> hot-unplug, right?
I'm wrong. drive should be hot-unplugged one by one, device will be removed by
slot. PCI device has multifunction feature, not drive.
> Best regards,
> -Gonglei
--
Amos.