[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/11] target-arm: reorganize gen_aa32_ld/st
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/11] target-arm: reorganize gen_aa32_ld/st to prepare for BE32 system emulation |
Date: |
Thu, 26 Jun 2014 15:38:26 +0100 |
On 21 June 2014 13:58, Paolo Bonzini <address@hidden> wrote:
> Extract everything to an inline function and simplify DO_GEN_LD/DO_GEN_ST.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> DO_GEN_LD(8s, MO_SB)
> DO_GEN_LD(8u, MO_UB)
> DO_GEN_LD(16s, MO_SW)
> DO_GEN_LD(16u, MO_UW)
> -DO_GEN_LD(32u, MO_UL)
> DO_GEN_ST(8, MO_UB)
> DO_GEN_ST(16, MO_UW)
> +DO_GEN_LD(32u, MO_UL)
> DO_GEN_ST(32, MO_UL)
Why move this DO_GEN_LD invocation in amongst the DO_GEN_STs?
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
-- PMM
- Re: [Qemu-devel] [PATCH v3 06/11] target-arm: implement SCTLR.EE, (continued)
- [Qemu-devel] [PATCH v3 05/11] linux-user: arm: handle CPSR.E correctly in strex emulation, Paolo Bonzini, 2014/06/21
- [Qemu-devel] [PATCH v3 07/11] target-arm: pass DisasContext to gen_aa32_ld*/st*, Paolo Bonzini, 2014/06/21
- [Qemu-devel] [PATCH v3 08/11] target-arm: introduce tbflag for CPSR.E, Paolo Bonzini, 2014/06/21
- [Qemu-devel] [PATCH v3 09/11] target-arm: implement setend, Paolo Bonzini, 2014/06/21
- [Qemu-devel] [PATCH v3 10/11] target-arm: reorganize gen_aa32_ld/st to prepare for BE32 system emulation, Paolo Bonzini, 2014/06/21
- Re: [Qemu-devel] [PATCH v3 10/11] target-arm: reorganize gen_aa32_ld/st to prepare for BE32 system emulation,
Peter Maydell <=
- [Qemu-devel] [PATCH v3 11/11] target-arm: implement BE32 mode in system emulation, Paolo Bonzini, 2014/06/21