qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR an


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR
Date: Thu, 26 Jun 2014 17:37:49 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

> From: Wenchao Xia <address@hidden>
>
> Signed-off-by: Wenchao Xia <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

This broke tests/qemu-iotests/041.  Apparently, the BLOCK_JOB_ERROR
event changed from

    {'timestamp': {'seconds': 1403796871, 'microseconds': 446502},
     'data': {'device': 'drive0',
              'action': 'ignore',
              'operation': 'write'},
     'event': 'BLOCK_JOB_ERROR'}

to

    {'timestamp': {'seconds': 1403796674, 'microseconds': 63271},
     'data': {'device': '',
              'action': 'report',
              'operation': 'write'},
     'event': 'BLOCK_JOB_ERROR'}

losing the value of device, which breaks qemu-iotests/041's tests of
data/device.

Please fix.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]