Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR

[Markus Armbruster]

Markus Armbruster <address@hidden> writes:

> Paolo Bonzini <address@hidden> writes:
>
>> Il 26/06/2014 17:37, Markus Armbruster ha scritto:
>>> Paolo Bonzini <address@hidden> writes:
>>> 
>>>> From: Wenchao Xia <address@hidden>
>>>>
>>>> Signed-off-by: Wenchao Xia <address@hidden>
>>>> Signed-off-by: Paolo Bonzini <address@hidden>
>>> 
>>> This broke tests/qemu-iotests/041.  Apparently, the BLOCK_JOB_ERROR
>>> event changed from
>>> 
>>>     {'timestamp': {'seconds': 1403796871, 'microseconds': 446502},
>>>      'data': {'device': 'drive0',
>>
>> - bdrv_emit_qmp_error_event(job->bs, QEVENT_BLOCK_JOB_ERROR, action,
>> is_read);
>> +    qapi_event_send_block_job_error(bdrv_get_device_name(bs),
>>
>> Should have been job->bs.
>
> Will you post a patch, or would you like me to do that?
>
>>>               'action': 'ignore',
>>>               'operation': 'write'},
>>>      'event': 'BLOCK_JOB_ERROR'}
>>> 
>>> to
>>> 
>>>     {'timestamp': {'seconds': 1403796674, 'microseconds': 63271},
>>>      'data': {'device': '',
>>>               'action': 'report',
>>
>> I suppose ignore vs. report is just from pasting two different sections?
>
> Could well be; it's almost time for Fußball & Bier ;)

Nope, it's a genuine error in the patch.  Working on a fix.