qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RESEND v1 8/8] target-microblaze: Remove dead co


From: Edgar E. Iglesias
Subject: Re: [Qemu-devel] [PATCH RESEND v1 8/8] target-microblaze: Remove dead code
Date: Fri, 5 Jun 2015 10:48:30 +1000
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Jun 04, 2015 at 11:25:49AM +1000, Alistair Francis wrote:
> This code is already being run in the mb_cpu_realizefn()
> function. As PVR registers are preserved on reset this
> code is not required.

Reviewed-by: Edgar E. Iglesias <address@hidden>


> 
> Signed-off-by: Alistair Francis <address@hidden>
> ---
>  target-microblaze/cpu.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
> index 329d4d5..437250d 100644
> --- a/target-microblaze/cpu.c
> +++ b/target-microblaze/cpu.c
> @@ -129,10 +129,6 @@ static void mb_cpu_realizefn(DeviceState *dev, Error 
> **errp)
>  
>      env->sregs[SR_PC] = cpu->cfg.base_vectors;
>  
> -#if defined(CONFIG_USER_ONLY)
> -    env->pvr.regs[10] = 0x0c000000; /* Spartan 3a dsp.  */
> -#endif
> -
>      mcc->parent_realize(dev, errp);
>  }
>  
> -- 
> 1.7.1
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]