qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 0/2] fw_cfg: *prequel* to cleanup series


From: Gabriel L. Somlo
Subject: [Qemu-devel] [PATCH 0/2] fw_cfg: *prequel* to cleanup series
Date: Mon, 8 Jun 2015 14:10:43 -0400

The fw_cfg cleanup series exposed a memory leak occurring on ppc and sparc
machine types.

This series adds a safe fw_cfg integer-type update function (1/2), and
modifies ppc and sparc callbacks to use it instead of the current leaky
method (2/2).

This should preferably go in *before* "fw_cfg: remove support for guest-side 
data writes", which would otherwise cause certain ppc and sparc command
lines to crash.

Once these are reviewed (also, see additional questions in 1/1), should I
re-spin the whole set, or keep these two as a separate, independent series?

Thanks,
  Gabriel

Gabriel L. Somlo (2):
  fw_cfg: add fw_cfg_modify_i16 (update) method
  fw_cfg: fix FW_CFG_BOOT_DEVICE value update on ppc and sparc[64]

 hw/nvram/fw_cfg.c         | 10 ++++++++++
 hw/ppc/mac_newworld.c     |  2 +-
 hw/ppc/mac_oldworld.c     |  2 +-
 hw/sparc/sun4m.c          |  2 +-
 hw/sparc64/sun4u.c        |  2 +-
 include/hw/nvram/fw_cfg.h |  1 +
 6 files changed, 15 insertions(+), 4 deletions(-)

-- 
2.1.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]