qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] fw_cfg: *prequel* to cleanup series


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 0/2] fw_cfg: *prequel* to cleanup series
Date: Tue, 09 Jun 2015 10:15:45 +0200

On Mo, 2015-06-08 at 14:10 -0400, Gabriel L. Somlo wrote:
> The fw_cfg cleanup series exposed a memory leak occurring on ppc and sparc
> machine types.
> 
> This series adds a safe fw_cfg integer-type update function (1/2), and
> modifies ppc and sparc callbacks to use it instead of the current leaky
> method (2/2).
> 
> This should preferably go in *before* "fw_cfg: remove support for guest-side 
> data writes", which would otherwise cause certain ppc and sparc command
> lines to crash.
> 
> Once these are reviewed (also, see additional questions in 1/1), should I
> re-spin the whole set, or keep these two as a separate, independent series?

Keeping separate is fine, I'll order the patches via 'git rebase'.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]