[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] qdev-monitor: Propagate errors through qdev
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] qdev-monitor: Propagate errors through qdev_device_add() |
Date: |
Mon, 08 Jun 2015 14:04:04 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/08/2015 12:57 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> include/monitor/qdev.h | 2 +-
> qdev-monitor.c | 36 +++++++++++++++---------------------
> vl.c | 7 +++++--
> 3 files changed, 21 insertions(+), 24 deletions(-)
>
> if (!object_dynamic_cast(OBJECT(bus), dc->bus_type)) {
> - qerror_report(ERROR_CLASS_GENERIC_ERROR,
> - "Device '%s' can't go on a %s bus",
> - driver, object_get_typename(OBJECT(bus)));
> + error_setg(errp, "Device '%s' can't go on a %s bus",
> + driver, object_get_typename(OBJECT(bus)));
Pre-existing - "a '%s' bus" or "an %s bus" might look a bit nicer than
"a %s bus" for some bus names (depends on the initial sound during
pronunciation). Certainly a nightmare for translation rules to other
languages that don't follow English rules on indefinite article usage.
Maybe some word-smithing can avoid the indefinite article altogether?
But not something I care about enough to hold up the series.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 4/7] qdev-monitor: Fix check for full bus, (continued)
- [Qemu-devel] [PATCH 4/7] qdev-monitor: Fix check for full bus, Markus Armbruster, 2015/06/08
- [Qemu-devel] [PATCH 3/7] qdev-monitor: Stop error avalance in qbus_find_recursive(), Markus Armbruster, 2015/06/08
- [Qemu-devel] [PATCH 5/7] qdev-monitor: Convert qbus_find() to Error, Markus Armbruster, 2015/06/08
- [Qemu-devel] [PATCH 1/7] qdev: Deprecated qdev_init() is finally unused, drop, Markus Armbruster, 2015/06/08
- [Qemu-devel] [PATCH 7/7] qdev-monitor: Propagate errors through qdev_device_add(), Markus Armbruster, 2015/06/08
- Re: [Qemu-devel] [PATCH 7/7] qdev-monitor: Propagate errors through qdev_device_add(),
Eric Blake <=