[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] qdev-monitor: Propagate errors through qdev
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] qdev-monitor: Propagate errors through qdev_device_add() |
Date: |
Tue, 09 Jun 2015 04:54:45 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/09/2015 12:12 AM, Markus Armbruster wrote:
>>
>>> if (!object_dynamic_cast(OBJECT(bus), dc->bus_type)) {
>>> - qerror_report(ERROR_CLASS_GENERIC_ERROR,
>>> - "Device '%s' can't go on a %s bus",
>>> - driver, object_get_typename(OBJECT(bus)));
>>> + error_setg(errp, "Device '%s' can't go on a %s bus",
>>> + driver, object_get_typename(OBJECT(bus)));
>>
>> Pre-existing - "a '%s' bus" or "an %s bus" might look a bit nicer than
>> "a %s bus" for some bus names (depends on the initial sound during
>> pronunciation). Certainly a nightmare for translation rules to other
>> languages that don't follow English rules on indefinite article usage.
>
> For a real nightmare, try following every other language's rules[*].
> Not following English rules will feel like a lullaby after that.
>
>> Maybe some word-smithing can avoid the indefinite article altogether?
>
> Do you think "Device '%s' can't go on %s bus" would be an improvement?
Yes, I think that works.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 3/7] qdev-monitor: Stop error avalance in qbus_find_recursive(), (continued)