[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/13] qdict: Add qdict_{set, copy}_default()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/13] qdict: Add qdict_{set, copy}_default() |
Date: |
Wed, 10 Jun 2015 15:29:17 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/10/2015 07:46 AM, Kevin Wolf wrote:
> In the block layer functions that determine options for a child block
> device, it's a common pattern to either copy options from the parent's
> options or to set a default string if the option isn't explicitly set
> yet for the child. Provide convenience functions so that it becomes a
> one-liner for each option.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> include/qapi/qmp/qdict.h | 3 +++
> qobject/qdict.c | 33 +++++++++++++++++++++++++++++++++
> 2 files changed, 36 insertions(+)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/13] bdrv_reopen() overhaul, part 1, Kevin Wolf, 2015/06/10
- [Qemu-devel] [PATCH v2 01/13] qdict: Add qdict_array_entries(), Kevin Wolf, 2015/06/10
- [Qemu-devel] [PATCH v2 06/13] block: Use macro for cache option names, Kevin Wolf, 2015/06/10
- [Qemu-devel] [PATCH v2 03/13] check-qdict: Test cases for new functions, Kevin Wolf, 2015/06/10
- [Qemu-devel] [PATCH v2 02/13] qdict: Add qdict_{set, copy}_default(), Kevin Wolf, 2015/06/10
- Re: [Qemu-devel] [PATCH v2 02/13] qdict: Add qdict_{set, copy}_default(),
Eric Blake <=
- [Qemu-devel] [PATCH v2 05/13] vmdk: Use bdrv_open_image(), Kevin Wolf, 2015/06/10
- [Qemu-devel] [PATCH v2 07/13] block: Use QemuOpts in bdrv_open_common(), Kevin Wolf, 2015/06/10
- [Qemu-devel] [PATCH v2 04/13] quorum: Use bdrv_open_image(), Kevin Wolf, 2015/06/10
- [Qemu-devel] [PATCH v2 09/13] block: Drain requests before swapping nodes in bdrv_swap(), Kevin Wolf, 2015/06/10
- [Qemu-devel] [PATCH v2 10/13] queue.h: Add QLIST_FIX_HEAD_PTR(), Kevin Wolf, 2015/06/10