Re: [Qemu-devel] [PATCH 01/11] QemuOpts: Wean off qerror_report_err()

[Eric Blake]

On 06/13/2015 08:20 AM, Markus Armbruster wrote:
> qerror_report_err() is a transitional interface to help with
> converting existing monitor commands to QMP.  It should not be used
> elsewhere.
> 
> The only remaining user in qemu-option.c is qemu_opts_parse().  Is it
> used in QMP context?  If not, we can simply replace
> qerror_report_err() by error_report_err().
> 

> 
> Propoagate errors through qemu_opts_parse().  Create a convenience

s/Propoagate/Propagate/

> function qemu_opts_parse_noisily() that passes errors to
> error_report_err().  Switch all non-QMP users outside tests to it.
> 
> That leaves vnc_parse_func().  Propagate errors through it.  Since I'm
> touching it anyway, rename it to vnc_parse().
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature