qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/11] Include monitor/monitor.h exactly where n


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 11/11] Include monitor/monitor.h exactly where needed
Date: Mon, 15 Jun 2015 15:40:32 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 06/13/2015 08:20 AM, Markus Armbruster wrote:
> In particular, don't include it into headers.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

>  29 files changed, 4 insertions(+), 29 deletions(-)

Again, it might be nice to call out in the commit message how you
determined which files could drop it (was it via blanket deletion, then
re-add if compilation failed?).  But doesn't impact the patch being a
nice cleanup, so:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]