[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers on f
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers on forward jumps |
Date: |
Wed, 17 Jun 2015 16:00:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 12/06/2015 16:08, Paul Donohue wrote:
> +static inline int64_t get_max_clock_jump(void)
> +{
> + // This should be small enough to prevent excessive interrupts from being
> + // generated by the RTC on clock jumps, but large enough to avoid
> frequent
> + // unnecessary resets in idle VMs.
This is not how comments are layed out in QEMU...
> + return 60 * get_ticks_per_sec();
> +}
> +
> /*
> * * Low level clock functions
> * */
... and it also looks like your editor has mangled this patch.
Nevertheless, I've applied it to my local branch and will send it out
for inclusion after some more testing.
Paolo
> diff --git a/qemu-timer.c b/qemu-timer.c
> index 5741f0d..d27be3d 100644
> --- a/qemu-timer.c
> +++ b/qemu-timer.c