Re: [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers on forward jumps

[Paolo Bonzini]

On 18/06/2015 14:58, Paul Donohue wrote:
> On Wed, Jun 17, 2015 at 04:00:06PM +0200, Paolo Bonzini wrote:
>> On 12/06/2015 16:08, Paul Donohue wrote:
>>> +static inline int64_t get_max_clock_jump(void)
>>> +{
>>> +    // This should be small enough to prevent excessive interrupts from 
>>> being
>>> +    // generated by the RTC on clock jumps, but large enough to avoid 
>>> frequent
>>> +    // unnecessary resets in idle VMs.
>> This is not how comments are layed out in QEMU...
> Oops.  Sorry, I'm not sure how I missed that.  Force of habit from 
> other projects, I guess...
> 
>>> +    return 60 * get_ticks_per_sec();
>>> +}
>>> +
>>>  /*
>>>  *   * Low level clock functions
>>>  *     */
>> ... and it also looks like your editor has mangled this patch.
> Ugh, yes.  I do remember noticing that, and I thought I fixed it, but 
> apparently not.
> 
> I will correct and send an updated patch.

No problem, I fixed this already.

Paolo