[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Check value for invalid nega
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Check value for invalid negative values |
Date: |
Wed, 17 Jun 2015 22:27:10 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 |
11.06.2015 16:17, Frediano Ziglio wrote:
> In qxl_v2n check that value is not negative.
Why do you think it is necessary?
Thanks,
/mjt
> Signed-off-by: Frediano Ziglio <address@hidden>
> ---
> hw/display/qxl-logger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/qxl-logger.c b/hw/display/qxl-logger.c
> index d944d3f..faed869 100644
> --- a/hw/display/qxl-logger.c
> +++ b/hw/display/qxl-logger.c
> @@ -93,7 +93,7 @@ static const char *const spice_cursor_type[] = {
>
> static const char *qxl_v2n(const char *const n[], size_t l, int v)
> {
> - if (v >= l || !n[v]) {
> + if (v < 0 || v >= l || !n[v]) {
> return "???";
> }
> return n[v];
Re: [Qemu-devel] [PATCH 1/2] Constify some variable, Michael Tokarev, 2015/06/17