[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target |
Date: |
Thu, 18 Jun 2015 13:55:33 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jun 18, 2015 at 04:49:12PM +0800, Wen Congyang wrote:
> +void bdrv_connect(BlockDriverState *bs, Error **errp)
> +{
> + BlockDriver *drv = bs->drv;
> +
> + if (drv && drv->bdrv_connect) {
> + drv->bdrv_connect(bs, errp);
> + } else if (bs->file) {
> + bdrv_connect(bs->file, errp);
> + } else {
> + error_setg(errp, "this feature or command is not currently
> supported");
> + }
> +}
> +
> +void bdrv_disconnect(BlockDriverState *bs)
> +{
> + BlockDriver *drv = bs->drv;
> +
> + if (drv && drv->bdrv_disconnect) {
> + drv->bdrv_disconnect(bs);
> + } else if (bs->file) {
> + bdrv_disconnect(bs->file);
> + }
> +}
Please add doc comments describing the semantics of these commands.
Why are these operations needed when there is already a bs->drv == NULL
case which means the BDS is not ready for read/write?
pgpOwymnZFkKt.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH COLO-Block v6 01/16] docs: block replication's description, (continued)
- [Qemu-devel] [PATCH COLO-Block v6 03/16] Allow creating backup jobs when opening BDS, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 02/16] allow writing to the backing file, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 05/16] Backup: clear all bitmap when doing block checkpoint, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 06/16] Don't allow a disk use backing reference target, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target, Wen Congyang, 2015/06/18
- Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target, Wen Congyang, 2015/06/18
- Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target, Stefan Hajnoczi, 2015/06/18
- Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target, Wen Congyang, 2015/06/18
- Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target, Stefan Hajnoczi, 2015/06/19
- Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target, Wen Congyang, 2015/06/19
- Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target, Stefan Hajnoczi, 2015/06/22
- Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target, Wen Congyang, 2015/06/22
- Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target, Stefan Hajnoczi, 2015/06/23
- Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target, Wen Congyang, 2015/06/23
- Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target, Dr. David Alan Gilbert, 2015/06/24