[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/16] ahci: check for ncq prdtl overflow
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 04/16] ahci: check for ncq prdtl overflow |
Date: |
Mon, 22 Jun 2015 15:16:33 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jun 19, 2015 at 09:50:35PM -0400, John Snow wrote:
> - /* Note: We calculate the sector count, but don't currently rely on it.
> - * The total size of the DMA buffer tells us the transfer size instead.
> */
> ncq_tfs->sector_count = ((uint16_t)ncq_fis->sector_count_high << 8) |
> ncq_fis->sector_count_low;
> + ahci_populate_sglist(ad, &ncq_tfs->sglist, 0);
> + size = ncq_tfs->sector_count * 512;
I just saw that a later patch addresses the sector_count inconsistency,
so I'm happy with this now.
pgp6SPr2xIklB.pgp
Description: PGP signature
[Qemu-devel] [PATCH 02/16] ahci: use shorter variables, John Snow, 2015/06/19
[Qemu-devel] [PATCH 05/16] ahci: separate prdtl from opts, John Snow, 2015/06/19
[Qemu-devel] [PATCH 08/16] ahci: clear error register before NCQ cmd, John Snow, 2015/06/19
[Qemu-devel] [PATCH 07/16] ahci: ncq sector count correction, John Snow, 2015/06/19
[Qemu-devel] [PATCH 09/16] libqos/ahci: fix cmd_sanity for ncq, John Snow, 2015/06/19
[Qemu-devel] [PATCH 10/16] libqos/ahci: add NCQ frame support, John Snow, 2015/06/19