[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/16] ahci: check for ncq prdtl overflow
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/16] ahci: check for ncq prdtl overflow |
|
Date: |
Tue, 23 Jun 2015 11:55:23 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/23/2015 09:46 AM, Stefan Hajnoczi wrote:
> On Mon, Jun 22, 2015 at 10:08:22AM -0400, John Snow wrote:
>> (sector_count == 0 means 64K sectors, though, like it does in regular
>> ATA.)
>
> I don't see a case to handle this.
>
I apologize:
Corrected in [PATCH 09/16] ahci: correct ncq sector count, in the "part
2" series.
Sorry for the confusing order, I played a lot of patch-reshuffling and
due to the refactors to get NCQ migrating, sometimes it was literally
just a sin of convenience to leave certain patches after the shuffle.
I tried to leave each patch fixing just one very small issue at a time
so they were easier to digest, instead of batching them together like
"Fix (everything wrong about) sector count." Maybe that wasn't the right
approach, you can let me know.
Thank you,
--John
[Qemu-devel] [PATCH 02/16] ahci: use shorter variables, John Snow, 2015/06/19
[Qemu-devel] [PATCH 05/16] ahci: separate prdtl from opts, John Snow, 2015/06/19
[Qemu-devel] [PATCH 08/16] ahci: clear error register before NCQ cmd, John Snow, 2015/06/19
[Qemu-devel] [PATCH 07/16] ahci: ncq sector count correction, John Snow, 2015/06/19
[Qemu-devel] [PATCH 09/16] libqos/ahci: fix cmd_sanity for ncq, John Snow, 2015/06/19