Re: [Qemu-devel] [SeaBIOS] [PATCH] ich9: initialise RCBA register through LPC interface

[Kevin O'Connor]

On Mon, Jun 22, 2015 at 03:06:06PM +0200, Paolo Bonzini wrote:
> On 27/05/2015 11:32, Paolo Bonzini wrote:
> > On 27/05/2015 02:28, Paulo Alcantara wrote:
> >> This patch initialises root complex register block BAR in order to
> >> support TCO watchdog emulation features on QEMU.
> >>
> >> Signed-off-by: Paulo Alcantara <address@hidden>
> >> ---
> >>  src/fw/dev-q35.h | 3 +++
> >>  src/fw/pciinit.c | 4 ++++
> >>  2 files changed, 7 insertions(+)
> >>
> >> diff --git a/src/fw/dev-q35.h b/src/fw/dev-q35.h
> >> index c6f8bd9..201825d 100644
> >> --- a/src/fw/dev-q35.h
> >> +++ b/src/fw/dev-q35.h
> >> @@ -27,6 +27,9 @@
> >>  #define ICH9_LPC_GEN_PMCON_1_SMI_LOCK  (1 << 4)
> >>  #define ICH9_LPC_PORT_ELCR1            0x4d0
> >>  #define ICH9_LPC_PORT_ELCR2            0x4d1
> >> +#define ICH9_LPC_RCBA                  0xf0
> >> +#define ICH9_LPC_RCBA_ADDR             0xfed1c000
> >> +#define ICH9_LPC_RCBA_EN               0x1
> >>  #define PCI_DEVICE_ID_INTEL_ICH9_SMBUS 0x2930
> >>  #define ICH9_SMB_SMB_BASE              0x20
> >>  #define ICH9_SMB_HOSTC                 0x40
> >> diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c
> >> index ac39d23..defccf3 100644
> >> --- a/src/fw/pciinit.c
> >> +++ b/src/fw/pciinit.c
> >> @@ -183,6 +183,10 @@ static void mch_isa_bridge_setup(struct pci_device 
> >> *dev, void *arg)
> >>      /* acpi enable, SCI: IRQ9 000b = irq9*/
> >>      pci_config_writeb(bdf, ICH9_LPC_ACPI_CTRL, 
> >> ICH9_LPC_ACPI_CTRL_ACPI_EN);
> >>  
> >> +    /* set root complex register block BAR */
> >> +    pci_config_writel(bdf, ICH9_LPC_RCBA,
> >> +                      ICH9_LPC_RCBA_ADDR | ICH9_LPC_RCBA_EN);
> >> +
> >>      acpi_pm1a_cnt = acpi_pm_base + 0x04;
> >>      pmtimer_setup(acpi_pm_base + 0x08);
> >>  }
> >>
> > 
> > Reviewed-by: Paolo Bonzini <address@hidden>
> > 
> > 
> 
> Ping?  If TCO support is added to QEMU 2.4, we need this patch too.

The patch looks fine to me.  But, for patches that require both
SeaBIOS and QEMU support I generally prefer to see the QEMU code
committed before committing the SeaBIOS part.

Sorry for the delay in responding.
-Kevin