[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/9] exec: pull qemu_flush_coalesced_mmio_buffer
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/9] exec: pull qemu_flush_coalesced_mmio_buffer() into address_space_rw/ld*/st* |
Date: |
Tue, 23 Jun 2015 11:12:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 23/06/2015 11:05, Fam Zheng wrote:
>> > diff --git a/memory.c b/memory.c
>> > index 6b77354..be385d4 100644
>> > --- a/memory.c
>> > +++ b/memory.c
>> > @@ -414,9 +414,6 @@ static MemTxResult
>> > memory_region_read_with_attrs_accessor(MemoryRegion *mr,
>> > uint64_t tmp = 0;
>> > MemTxResult r;
>> >
>> > - if (mr->flush_coalesced_mmio) {
>> > - qemu_flush_coalesced_mmio_buffer();
>> > - }
>> > r = mr->ops->read_with_attrs(mr->opaque, addr, &tmp, size, attrs);
>> > trace_memory_region_ops_read(mr, addr, tmp, size);
>> > *value |= (tmp & mask) << shift;
>> > @@ -449,9 +446,6 @@ static MemTxResult
>> > memory_region_write_accessor(MemoryRegion *mr,
>> > {
>> > uint64_t tmp;
>> >
>> > - if (mr->flush_coalesced_mmio) {
>> > - qemu_flush_coalesced_mmio_buffer();
>> > - }
>> > tmp = (*value >> shift) & mask;
>> > trace_memory_region_ops_write(mr, addr, tmp, size);
>> > mr->ops->write(mr->opaque, addr, tmp, size);
> Why are memory_region_read_accessor and
> memory_region_write_with_attrs_accessor
> unchanged?
Good catch. Botched the rebasing.
Paolo
[Qemu-devel] [PATCH 6/9] kvm: First step to push iothread lock out of inner run loop, Paolo Bonzini, 2015/06/18