[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS |
Date: |
Mon, 29 Jun 2015 11:55:29 +0200 |
On Fri, Jun 26, 2015 at 02:25:42PM +0200, Laszlo Ersek wrote:
> On 06/26/15 11:31, Markus Armbruster wrote:
> > Laszlo Ersek <address@hidden> writes:
> >
> >> With the pc-q35-2.4 machine type, if the user creates an ISA FDC manually:
> >>
> >> -device isa-fdc,driveA=drive-fdc0-0-0 \
> >> -drive file=...,if=none,id=drive-fdc0-0-0,format=raw
> >>
> >> then the board-default FDC will be skipped, and only the explicitly
> >> requested FDC will exist. qtree-wise, this is correct; however such an FDC
> >> is currently not registered in the CMOS, because that code is only reached
> >> for the board-default FDC.
> >>
> >> The pc_cmos_init_late() one-shot reset handler -- one-shot because the
> >> CMOS is not reprogrammed during warm reset -- should search for any ISA
> >> FDC devices, created implicitly (by board code) or explicitly, and set the
> >> CMOS accordingly to the ISA FDC(s) with iobase=0x3f0:
> >>
> >> - if there is no such FDC, report both drives absent,
> >> - if there is exactly one such FDC, report its drives in the CMOS,
> >> - if there are more than one such FDCs, then pick one (it is not specified
> >> which one), and print a warning about the ambiguity.
> >>
> >> Cc: Jan Tomko <address@hidden>
> >> Cc: John Snow <address@hidden>
> >> Cc: Markus Armbruster <address@hidden>
> >> Cc: Paolo Bonzini <address@hidden>
> >> Reported-by: Jan Tomko <address@hidden>
> >> Suggested-by: Markus Armbruster <address@hidden>
> >> Signed-off-by: Laszlo Ersek <address@hidden>
> >> Reviewed-by: John Snow <address@hidden>
> >
> > Reviewed-by: Markus Armbruster <address@hidden>
>
> Thank you. Can you or John please send a PULL req for this? (Or include
> it in an upcoming PULL of yours.)
>
> I've been Cc'ing Paolo because the get-maintainer script reported him at
> the top for the patch set, but I believe he might not have time for this
> now.
>
> Thanks!
> Laszlo
It's listed as part of PC in MAINTAINERS, but looks like
get-maintainer didn't recognize the format.
I fixed it up, will review and queue the patches.
--
MST
- [Qemu-devel] [PATCH v2 0/3] update CMOS for ISA-FDC with iobase=0x3f0, Laszlo Ersek, 2015/06/25
- [Qemu-devel] [PATCH v2 1/3] hw/i386/pc: factor out pc_cmos_init_floppy(), Laszlo Ersek, 2015/06/25
- [Qemu-devel] [PATCH v2 3/3] hw/i386/pc: don't carry FDC from pc_basic_device_init() to pc_cmos_init(), Laszlo Ersek, 2015/06/25
- [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS, Laszlo Ersek, 2015/06/25
- Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS, Markus Armbruster, 2015/06/26
- Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS, Laszlo Ersek, 2015/06/26
- Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS, John Snow, 2015/06/26
- Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS, Eduardo Habkost, 2015/06/26
- Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS, Markus Armbruster, 2015/06/29
- Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS, Michael S. Tsirkin, 2015/06/29
- Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS,
Michael S. Tsirkin <=