[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] MAINTAINERS: fix pattern for PC
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] MAINTAINERS: fix pattern for PC |
Date: |
Mon, 29 Jun 2015 11:00:07 +0100 |
On 29 June 2015 at 10:54, Michael S. Tsirkin <address@hidden> wrote:
> Looks like hw/i386/ does not work, hw/i386/*
> seems to work better.
This is kind of vague... The documentation at the top
of MAINTAINERS says the difference is that "hw/i386/"
means "all files in and below hw/i386/", whereas
"hw/i386/*" means "all files in hw/i386, but not below"
(so won't match anything in hw/i386/kvm/ or hw/i386/xen/).
Is this the effect you're trying to achieve? It would
be nice to mention the symptoms of the problem this patch
is fixing in the commit message...
> Reported-by: Laszlo Ersek <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3d48a6b..39a01ab 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -578,7 +578,7 @@ PC
> M: Michael S. Tsirkin <address@hidden>
> S: Supported
> F: include/hw/i386/
> -F: hw/i386/
> +F: hw/i386/*
> F: hw/pci-host/piix.c
> F: hw/pci-host/q35.c
> F: hw/pci-host/pam.c
thanks
-- PMM