[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [PATCH 10/18] virtio: add version 1.0 support
From: |
Kevin O'Connor |
Subject: |
Re: [Qemu-devel] [SeaBIOS] [PATCH 10/18] virtio: add version 1.0 support to vp_get_isr |
Date: |
Mon, 29 Jun 2015 10:00:01 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jun 29, 2015 at 10:53:32AM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> src/hw/virtio-pci.c | 12 ++++++++++++
> src/hw/virtio-pci.h | 6 +-----
> 2 files changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c
> index b414c71..481b365 100644
> --- a/src/hw/virtio-pci.c
> +++ b/src/hw/virtio-pci.c
> @@ -90,6 +90,18 @@ void vp_set_status(struct vp_device *vp, u8 status)
> }
> }
>
> +u8 vp_get_isr(struct vp_device *vp)
> +{
> + u8 isr;
> +
> + if (vp->use_modern) {
> + vp_modern_read(vp->isr, virtio_pci_isr, isr, isr);
> + } else {
> + isr = inb(vp->ioaddr + VIRTIO_PCI_ISR);
> + }
> + return isr;
> +}
How about renaming "use_modern" to something more descriptive - like
"use_abi1"? Also, couldn't vp_modern_read just be renamed to vp_read.
BTW, out of curiosity, did you consider retroactively making ABIv0
structs and using vp_read() for both the new and old cases? I'm not
sure it would save any code, but mixing the struct/offset/sizeof
method with the inb/define method seems a little awkward.
-Kevin
- [Qemu-devel] [PATCH 03/18] virtio: add struct vp_device, (continued)
- [Qemu-devel] [PATCH 08/18] virtio: make features 64bit, support version 1.0 features, Gerd Hoffmann, 2015/06/29
- [Qemu-devel] [PATCH 09/18] virtio: add version 1.0 support to vp_{get, set}_status, Gerd Hoffmann, 2015/06/29
- [Qemu-devel] [PATCH 10/18] virtio: add version 1.0 support to vp_get_isr, Gerd Hoffmann, 2015/06/29
- Re: [Qemu-devel] [SeaBIOS] [PATCH 10/18] virtio: add version 1.0 support to vp_get_isr,
Kevin O'Connor <=
[Qemu-devel] [PATCH 11/18] virtio: add version 1.0 support to vp_reset, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 13/18] virtio: remove unused vp_del_vq, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 12/18] virtio: add version 1.0 support to vp_notify, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 14/18] virtio: add version 1.0 support to vp_find_vq, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 15/18] virtio-scsi: fix initialization for version 1.0, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 16/18] virtio-blk: fix initialization for version 1.0, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 17/18] virtio: use version 1.0 if available (flip the big switch), Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 18/18] virtio: also probe version 1.0 pci ids, Gerd Hoffmann, 2015/06/29