[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [PATCH 10/18] virtio: add version 1.0 support
From: |
Kevin O'Connor |
Subject: |
Re: [Qemu-devel] [SeaBIOS] [PATCH 10/18] virtio: add version 1.0 support to vp_get_isr |
Date: |
Mon, 29 Jun 2015 10:36:38 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jun 29, 2015 at 04:33:54PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > +u8 vp_get_isr(struct vp_device *vp)
> > > +{
> > > + u8 isr;
> > > +
> > > + if (vp->use_modern) {
> > > + vp_modern_read(vp->isr, virtio_pci_isr, isr, isr);
> > > + } else {
> > > + isr = inb(vp->ioaddr + VIRTIO_PCI_ISR);
> > > + }
> > > + return isr;
> > > +}
> >
> > How about renaming "use_modern" to something more descriptive - like
> > "use_abi1"? Also, couldn't vp_modern_read just be renamed to vp_read.
>
> In both qemu and linux kernel "legacy" and "modern" are used for the two
> interface revisions (0.9.5 and 1.0), and I'd prefer to stay consistent
> with that.
Okay - that makes sense.
Thanks,
-Kevin
[Qemu-devel] [PATCH 11/18] virtio: add version 1.0 support to vp_reset, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 13/18] virtio: remove unused vp_del_vq, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 12/18] virtio: add version 1.0 support to vp_notify, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 14/18] virtio: add version 1.0 support to vp_find_vq, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 15/18] virtio-scsi: fix initialization for version 1.0, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 16/18] virtio-blk: fix initialization for version 1.0, Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 17/18] virtio: use version 1.0 if available (flip the big switch), Gerd Hoffmann, 2015/06/29
[Qemu-devel] [PATCH 18/18] virtio: also probe version 1.0 pci ids, Gerd Hoffmann, 2015/06/29
Re: [Qemu-devel] [SeaBIOS] [PATCH 00/18] virtio: add version 1.0 support, Kevin O'Connor, 2015/06/29