[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v12 11/18] spapr_drc: Expose 'null' in qom-get when
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH v12 11/18] spapr_drc: Expose 'null' in qom-get when there is no fdt |
Date: |
Mon, 29 Feb 2016 22:14:25 -0700 |
Now that the QMP output visitor supports an explicit null
output, we should utilize it to make it easier to diagnose
the difference between a missing fdt ('null') vs. a
present-but-empty one ('{}').
(Note that this reverts the behavior of commit ab8bf1d, taking
us back to the behavior of commit 6c2f9a1 [which in turn
stemmed from a crash fix in 1d10b44]; but that this time,
the change is intentional and not an accidental side-effect.)
Signed-off-by: Eric Blake <address@hidden>
Acked-by: David Gibson <address@hidden>
---
v12: tweak commit message
[no v10, v11]
v9: improved commit message
v8: rebase to 'name' motion
v7: new patch, based on discussion about spapr_drc.c
---
hw/ppc/spapr_drc.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index ef063c0..b1bf193 100644
--- a/hw/ppc/spapr_drc.c
+++ b/hw/ppc/spapr_drc.c
@@ -260,11 +260,7 @@ static void prop_get_fdt(Object *obj, Visitor *v, const
char *name,
void *fdt;
if (!drc->fdt) {
- visit_start_struct(v, name, NULL, 0, &err);
- if (!err) {
- visit_end_struct(v, &err);
- }
- error_propagate(errp, err);
+ visit_type_null(v, NULL, errp);
return;
}
--
2.5.0
- [Qemu-devel] [PATCH v12 10/18] qmp: Support explicit null during visits, (continued)
- [Qemu-devel] [PATCH v12 10/18] qmp: Support explicit null during visits, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 05/18] qmp-input: Don't consume input when checking has_member, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 07/18] qapi: Document visitor interfaces, add assertions, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 02/18] qapi: Guarantee NULL obj on input visitor callback error, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 12/18] qmp: Tighten output visitor rules, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 14/18] qapi-commands: Wrap argument visit in visit_start_struct, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 15/18] qom: Wrap prop visit in visit_start_struct, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 16/18] qmp-input: Require struct push to visit members of top dict, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 04/18] qmp-input: Clean up stack handling, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 08/18] tests: Add check-qnull, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 11/18] spapr_drc: Expose 'null' in qom-get when there is no fdt,
Eric Blake <=
- [Qemu-devel] [PATCH v12 13/18] qapi: Split visit_end_struct() into pieces, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 18/18] qapi: Change visit_type_FOO() to no longer return partial objects, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 09/18] qapi: Add visit_type_null() visitor, Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 17/18] qapi: Simplify semantics of visit_next_list(), Eric Blake, 2016/03/01
- [Qemu-devel] [PATCH v12 06/18] qmp-input: Refactor when list is advanced, Eric Blake, 2016/03/01