[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/19] qapi: Rename 'fields' to 'members' in
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/19] qapi: Rename 'fields' to 'members' in internal interface |
Date: |
Wed, 02 Mar 2016 18:15:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> C types and JSON objects don't have fields, but members. We
> shouldn't gratuitously invent terminology. This patch is a
> strict renaming of generator code and static genarated functions,
> plus the naming of the dummy filler member for empty structs,
> before the next patch exposes some of that naming to the rest of
> the code base.
>
> Suggested-by: Markus Armbruster <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v2: new patch
Patch looks good. You could split it into Python renames (no change to
generated code) and C renames. Only if you like the idea.
If you want to be *really* thorough: there's a "field" left in
tests/qapi-schema/qapi-schema-test.json, and a few in
docs/qapi-code-gen.txt.
- Re: [Qemu-devel] [PATCH v2 01/19] qapi: Rename 'fields' to 'members' in internal interface,
Markus Armbruster <=