[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/19] qapi: Rename 'fields' to 'members' in
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/19] qapi: Rename 'fields' to 'members' in internal interface |
Date: |
Wed, 2 Mar 2016 13:05:37 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/02/2016 10:15 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> C types and JSON objects don't have fields, but members. We
>> shouldn't gratuitously invent terminology. This patch is a
>> strict renaming of generator code and static genarated functions,
>> plus the naming of the dummy filler member for empty structs,
>> before the next patch exposes some of that naming to the rest of
>> the code base.
>>
>> Suggested-by: Markus Armbruster <address@hidden>
>> Signed-off-by: Eric Blake <address@hidden>
>>
>> ---
>> v2: new patch
>
> Patch looks good. You could split it into Python renames (no change to
> generated code) and C renames. Only if you like the idea.
Sure, not too much work.
>
> If you want to be *really* thorough: there's a "field" left in
> tests/qapi-schema/qapi-schema-test.json, and a few in
> docs/qapi-code-gen.txt.
I'll save docs/ for 3/19, but get the .json file fixed along with the
Python renames.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature