[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/3] ARM: add query-gic-capability SMP comman
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/3] ARM: add query-gic-capability SMP command |
Date: |
Tue, 8 Mar 2016 13:20:07 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Mar 07, 2016 at 10:55:54AM +0100, Andrea Bolognani wrote:
> I tested this both on a v2-only machine
>
> {"return": [
> {"emulated": false, "version": 3, "kernel": false},
> {"emulated": true, "version": 2, "kernel": true}
> ]}
>
> and on a v3-only machine
>
> {"return": [
> {"emulated": false, "version": 3, "kernel": true},
> {"emulated": true, "version": 2, "kernel": false}
> ]}
>
> The output looks good to me - I'll leave reviewing the
> implementation to someone with more QEMU knowledge than me, that
> is, any QEMU knowledge at all ;)
Appreciated for helping verify this! :-)
>
> One last, purely cosmetic, bit: should the command name be
> query-gic-capabilities rather than query-gic-capability? Any
> native speaker feels like weighing in?
Yah, it seems that "query-gic-capabilities" sounds better. Will use
that in next spin if no one oppose.
Thanks!
Peter