[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryReg
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal |
Date: |
Tue, 8 Mar 2016 16:54:29 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, 03/08 08:54, Janosch Frank wrote:
> On 03/07/2016 05:35 PM, Janosch Frank wrote:
> > On 03/07/2016 10:17 AM, Fam Zheng wrote:
> >> Signed-off-by: Fam Zheng <address@hidden>
> >>
> >> ---
> >>
> >> This goes after "[PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr" (or
> >> squashed into it if we want strict synchronization).
> >> ---
> >> scripts/dump-guest-memory.py | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
> >> index f274bf8..c0a2e99 100644
> >> --- a/scripts/dump-guest-memory.py
> >> +++ b/scripts/dump-guest-memory.py
> >> @@ -352,7 +352,7 @@ def memory_region_get_ram_ptr(memory_region):
> >> return
> >> (memory_region_get_ram_ptr(memory_region["alias"].dereference())
> >> + memory_region["alias_offset"])
> >>
> >> - return qemu_get_ram_ptr(memory_region["ram_addr"] & TARGET_PAGE_MASK)
> >> + return qemu_get_ram_ptr(memory_region["ram_block"]["offset"])
> >
> > If you get rid of TARGET_PAGE_MASK you might also want to get rid of its
> > definition, we only use it once.
> >
> > I only had a short look, I'll look through your patches tomorrow morning.
> >
> > Cheers
>
> Didn't see any obvious problems.
Great. The patches are merged now, thank you for taking a look at the series!
Fam
- [Qemu-devel] [PATCH v2 3/7] memory: Implement memory_region_get_ram_addr with mr->ram_block, (continued)
- [Qemu-devel] [PATCH v2 3/7] memory: Implement memory_region_get_ram_addr with mr->ram_block, Fam Zheng, 2016/03/01
- [Qemu-devel] [PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr, Fam Zheng, 2016/03/01
- Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal, Paolo Bonzini, 2016/03/07
- Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal, Janosch Frank, 2016/03/07
- Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal, Janosch Frank, 2016/03/08
- Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal,
Fam Zheng <=
[Qemu-devel] [PATCH v2 5/7] exec: Pass RAMBlock pointer to qemu_ram_free, Fam Zheng, 2016/03/01
[Qemu-devel] [PATCH v2 6/7] exec: Factor out section_covers_addr, Fam Zheng, 2016/03/01
[Qemu-devel] [PATCH v2 7/7] exec: Introduce AddressSpaceDispatch.mru_section, Fam Zheng, 2016/03/01
Re: [Qemu-devel] [PATCH v2 0/7] memory: Clean up MemoryRegion.ram_addr and optimize address_space_translate, Paolo Bonzini, 2016/03/01
Re: [Qemu-devel] [PATCH v2 0/7] memory: Clean up MemoryRegion.ram_addr and optimize address_space_translate, Laszlo Ersek, 2016/03/07